Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy preview with VRT/AAT reports (Take Two) #5537

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Jan 13, 2025

Reverts #5536

Changelog

New

Changed

Giving this another shot 🤞🏼

Added checks for deploy_preview_with_reports.yml to only run if ci.yml was triggered by a pull_request event. I suspect that it was deploying to production because it was being triggered by the merge_group and push events.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Only contains workflow changes

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: e52b0ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hussam-i-am hussam-i-am self-assigned this Jan 13, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.18 KB (0%)
packages/react/dist/browser.umd.js 104.52 KB (0%)

@hussam-i-am hussam-i-am marked this pull request as ready for review January 13, 2025 23:01
@hussam-i-am hussam-i-am requested a review from a team as a code owner January 13, 2025 23:01
@hussam-i-am hussam-i-am requested a review from camertron January 13, 2025 23:01

jobs:
build:
if: ${{ always() && github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.head_repository.full_name == 'primer/react' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added github.event.workflow_run.event == 'pull_request' checks to each job to only run for pull_request events

@hussam-i-am hussam-i-am changed the title Revert "revert: restore deploy preview behavior" Deploy preview with VRT/AAT reports (Take Twio) Jan 14, 2025
@hussam-i-am hussam-i-am changed the title Deploy preview with VRT/AAT reports (Take Twio) Deploy preview with VRT/AAT reports (Take Two) Jan 14, 2025
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I really don't know much about workflows so good luck 😄

@hussam-i-am hussam-i-am added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 4ababd8 Jan 14, 2025
40 of 41 checks passed
@hussam-i-am hussam-i-am deleted the revert-5536-chore/remove-deploy-previews branch January 14, 2025 18:00
@hussam-i-am hussam-i-am restored the revert-5536-chore/remove-deploy-previews branch January 14, 2025 18:10
hussam-i-am added a commit that referenced this pull request Jan 14, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 14, 2025
hussam-i-am added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants