-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy preview with VRT/AAT reports (Take Two) #5537
Conversation
This reverts commit 15270ac.
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
|
||
jobs: | ||
build: | ||
if: ${{ always() && github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.head_repository.full_name == 'primer/react' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added github.event.workflow_run.event == 'pull_request'
checks to each job to only run for pull_request
events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but I really don't know much about workflows so good luck 😄
This reverts commit 4ababd8.
Reverts #5536
Changelog
New
Changed
Giving this another shot 🤞🏼
Added checks for
deploy_preview_with_reports.yml
to only run ifci.yml
was triggered by apull_request
event. I suspect that it was deploying to production because it was being triggered by themerge_group
andpush
events.Removed
Rollout strategy
Only contains workflow changes
Testing & Reviewing
Merge checklist