Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add guide to deploying a real-time app with ppg #6591

Merged
merged 26 commits into from
Jan 21, 2025
Merged

feat: add guide to deploying a real-time app with ppg #6591

merged 26 commits into from
Jan 21, 2025

Conversation

ankur-arch
Copy link
Contributor

Closes DA-2265

@ankur-arch ankur-arch self-assigned this Jan 12, 2025
Copy link
Contributor

github-actions bot commented Jan 12, 2025

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2025

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 817b9e5
Status: ✅  Deploy successful!
Preview URL: https://d75b6154.docs-51g.pages.dev
Branch Preview URL: https://da-2265.docs-51g.pages.dev

View logs

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 20.6%, saving 70.43 KB.

Filename Before After Improvement Visual comparison
static/img/guides/realtime-app-with-ppg.png 342.19 KB 271.76 KB -20.6% View diff

168 images did not require optimisation.

Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great guide 💯 a few notes (I added these as direct comments/suggestions as well but want to emphasize them as top-level feedback too):

  • when you use "sub-steps", please prefix the step with the current "top-level" step (see my comments in sections 3, 4 and 5)
  • please make sure to keep indentation of code blocks in lists at 2 or 4 spaces (two should normally be enough actually)
  • the real-time functionality didn't work for me; I added a Loom video with a demo in a comment

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 20.6%, saving 70.64 KB.

Filename Before After Improvement Visual comparison
static/img/guides/realtime-app-with-ppg.png 343.22 KB 272.58 KB -20.6% View diff

168 images did not require optimisation.

nikolasburk
nikolasburk previously approved these changes Jan 16, 2025
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work Ankur!

….mdx

Co-authored-by: Jon Harrell <4829245+jharrell@users.noreply.github.com>
….mdx

Co-authored-by: Jon Harrell <4829245+jharrell@users.noreply.github.com>
@jharrell jharrell merged commit 60583ea into main Jan 21, 2025
12 checks passed
@jharrell jharrell deleted the DA-2265 branch January 21, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants