Skip to content

Reimplement keygen_vk for fe-be split as keygen_vk_v2 #247

Reimplement keygen_vk for fe-be split as keygen_vk_v2

Reimplement keygen_vk for fe-be split as keygen_vk_v2 #247

Triggered via push December 13, 2023 16:37
Status Success
Total duration 1m 52s
Artifacts

lints-beta.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

9 warnings
multiple fields are never read: halo2_proofs/src/plonk/circuit.rs#L1569
warning: multiple fields are never read --> halo2_proofs/src/plonk/circuit.rs:1569:16 | 1568 | pub struct ConstraintSystemV2Backend<F: Field> { | ------------------------- fields in this struct 1569 | pub(crate) num_fixed_columns: usize, | ^^^^^^^^^^^^^^^^^ 1570 | pub(crate) num_advice_columns: usize, | ^^^^^^^^^^^^^^^^^^ 1571 | pub(crate) num_instance_columns: usize, | ^^^^^^^^^^^^^^^^^^^^ 1572 | // pub(crate) num_selectors: usize, 1573 | pub(crate) num_challenges: usize, | ^^^^^^^^^^^^^^ ... 1576 | pub(crate) unblinded_advice_columns: Vec<usize>, | ^^^^^^^^^^^^^^^^^^^^^^^^ ... 1579 | pub(crate) advice_column_phase: Vec<sealed::Phase>, | ^^^^^^^^^^^^^^^^^^^ 1580 | /// Contains the phase for each challenge. Should have same length as num_challenges. 1581 | pub(crate) challenge_phase: Vec<sealed::Phase>, | ^^^^^^^^^^^^^^^ ... 1608 | pub(crate) general_column_annotations: HashMap<metadata::Column, String>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
fields `domain`, `fixed_commitments`, `permutation`, `cs` and `cs_degree` are never read: halo2_proofs/src/plonk.rs#L50
warning: fields `domain`, `fixed_commitments`, `permutation`, `cs` and `cs_degree` are never read --> halo2_proofs/src/plonk.rs:50:5 | 49 | pub struct VerifyingKeyV2<C: CurveAffine> { | -------------- fields in this struct 50 | domain: EvaluationDomain<C::Scalar>, | ^^^^^^ 51 | fixed_commitments: Vec<C>, | ^^^^^^^^^^^^^^^^^ 52 | permutation: permutation::VerifyingKey<C>, | ^^^^^^^^^^^ 53 | cs: ConstraintSystemV2Backend<C::Scalar>, | ^^ 54 | /// Cached maximum degree of `cs` (which doesn't change after construction). 55 | cs_degree: usize, | ^^^^^^^^^ | = note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
multiple fields are never read: halo2_proofs/src/plonk/circuit.rs#L1569
warning: multiple fields are never read --> halo2_proofs/src/plonk/circuit.rs:1569:16 | 1568 | pub struct ConstraintSystemV2Backend<F: Field> { | ------------------------- fields in this struct 1569 | pub(crate) num_fixed_columns: usize, | ^^^^^^^^^^^^^^^^^ 1570 | pub(crate) num_advice_columns: usize, | ^^^^^^^^^^^^^^^^^^ 1571 | pub(crate) num_instance_columns: usize, | ^^^^^^^^^^^^^^^^^^^^ 1572 | // pub(crate) num_selectors: usize, 1573 | pub(crate) num_challenges: usize, | ^^^^^^^^^^^^^^ ... 1576 | pub(crate) unblinded_advice_columns: Vec<usize>, | ^^^^^^^^^^^^^^^^^^^^^^^^ ... 1579 | pub(crate) advice_column_phase: Vec<sealed::Phase>, | ^^^^^^^^^^^^^^^^^^^ 1580 | /// Contains the phase for each challenge. Should have same length as num_challenges. 1581 | pub(crate) challenge_phase: Vec<sealed::Phase>, | ^^^^^^^^^^^^^^^ ... 1608 | pub(crate) general_column_annotations: HashMap<metadata::Column, String>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
fields `domain`, `fixed_commitments`, `permutation`, `cs` and `cs_degree` are never read: halo2_proofs/src/plonk.rs#L50
warning: fields `domain`, `fixed_commitments`, `permutation`, `cs` and `cs_degree` are never read --> halo2_proofs/src/plonk.rs:50:5 | 49 | pub struct VerifyingKeyV2<C: CurveAffine> { | -------------- fields in this struct 50 | domain: EvaluationDomain<C::Scalar>, | ^^^^^^ 51 | fixed_commitments: Vec<C>, | ^^^^^^^^^^^^^^^^^ 52 | permutation: permutation::VerifyingKey<C>, | ^^^^^^^^^^^ 53 | cs: ConstraintSystemV2Backend<C::Scalar>, | ^^ 54 | /// Cached maximum degree of `cs` (which doesn't change after construction). 55 | cs_degree: usize, | ^^^^^^^^^ | = note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/