warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/plonk/prover.rs:459:29 | 459 | ... &domain, | ^^^^^^^ help: change this to: `domain` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` --> halo2_proofs/src/plonk/prover.rs:438:22 | 438 | let advice = std::mem::replace(&mut self.advice, Vec::new()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.advice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default

warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` --> halo2_proofs/src/plonk/prover.rs:437:24 | 437 | let instance = std::mem::replace(&mut self.instance, Vec::new()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.instance)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default = note: `-W clippy::mem-replace-with-default` implied by `-W clippy::all`

warning: this `if` has identical blocks --> halo2_proofs/src/plonk/prover.rs:338:55 | 338 | if column_indices.contains(&column_index) { | _______________________________________________________^ 339 | | // TODO: Check that column_index in witness is Some 340 | | // TODO: Check that the column length is `params.n()` 341 | | } else { | |_____________^ | note: same as this --> halo2_proofs/src/plonk/prover.rs:341:20 | 341 | } else { | ____________________^ 342 | | // TODO: Check that column_index in witness is None 343 | | }; | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else = note: `-W clippy::if-same-then-else` implied by `-W clippy::all`

warning: useless use of `format!` --> halo2_proofs/src/plonk/prover.rs:328:37 | 328 | return Err(Error::Other(format!("witness.len() != instance.len()"))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"witness.len() != instance.len()".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `-W clippy::useless-format` implied by `-W clippy::all`

warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_proofs/src/plonk/prover.rs:289:18 | 289 | witness: Vec<Vec<Option<Polynomial<Assigned<Scheme::Scalar>, LagrangeCoeff>>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `-W clippy::type-complexity` implied by `-W clippy::all`

warning: fields `num_fixed_columns` and `general_column_annotations` are never read --> halo2_proofs/src/plonk/circuit.rs:1594:16 | 1593 | pub struct ConstraintSystemV2Backend<F: Field> { | ------------------------- fields in this struct 1594 | pub(crate) num_fixed_columns: usize, | ^^^^^^^^^^^^^^^^^ ... 1633 | pub(crate) general_column_annotations: HashMap<metadata::Column, String>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

warning: fields `fixed_commitments` and `permutation` are never read --> halo2_proofs/src/plonk.rs:51:5 | 49 | pub struct VerifyingKeyV2<C: CurveAffine> { | -------------- fields in this struct 50 | domain: EvaluationDomain<C::Scalar>, 51 | fixed_commitments: Vec<C>, | ^^^^^^^^^^^^^^^^^ 52 | permutation: permutation::VerifyingKey<C>, | ^^^^^^^^^^^ | = note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: unused variable: `advice_column` --> halo2_proofs/src/plonk/prover.rs:337:28 | 337 | for (column_index, advice_column) in witness.iter().enumerate() { | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_advice_column` | = note: `#[warn(unused_variables)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/plonk/prover.rs:459:29 | 459 | ... &domain, | ^^^^^^^ help: change this to: `domain` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` --> halo2_proofs/src/plonk/prover.rs:438:22 | 438 | let advice = std::mem::replace(&mut self.advice, Vec::new()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.advice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default

warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` --> halo2_proofs/src/plonk/prover.rs:437:24 | 437 | let instance = std::mem::replace(&mut self.instance, Vec::new()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.instance)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default = note: `-W clippy::mem-replace-with-default` implied by `-W clippy::all`

warning: this `if` has identical blocks --> halo2_proofs/src/plonk/prover.rs:338:55 | 338 | if column_indices.contains(&column_index) { | _______________________________________________________^ 339 | | // TODO: Check that column_index in witness is Some 340 | | // TODO: Check that the column length is `params.n()` 341 | | } else { | |_____________^ | note: same as this --> halo2_proofs/src/plonk/prover.rs:341:20 | 341 | } else { | ____________________^ 342 | | // TODO: Check that column_index in witness is None 343 | | }; | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else = note: `-W clippy::if-same-then-else` implied by `-W clippy::all`

warning: useless use of `format!` --> halo2_proofs/src/plonk/prover.rs:328:37 | 328 | return Err(Error::Other(format!("witness.len() != instance.len()"))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"witness.len() != instance.len()".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `-W clippy::useless-format` implied by `-W clippy::all`

warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_proofs/src/plonk/prover.rs:289:18 | 289 | witness: Vec<Vec<Option<Polynomial<Assigned<Scheme::Scalar>, LagrangeCoeff>>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `-W clippy::type-complexity` implied by `-W clippy::all`

warning: fields `num_fixed_columns` and `general_column_annotations` are never read --> halo2_proofs/src/plonk/circuit.rs:1594:16 | 1593 | pub struct ConstraintSystemV2Backend<F: Field> { | ------------------------- fields in this struct 1594 | pub(crate) num_fixed_columns: usize, | ^^^^^^^^^^^^^^^^^ ... 1633 | pub(crate) general_column_annotations: HashMap<metadata::Column, String>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

warning: fields `fixed_commitments` and `permutation` are never read --> halo2_proofs/src/plonk.rs:51:5 | 49 | pub struct VerifyingKeyV2<C: CurveAffine> { | -------------- fields in this struct 50 | domain: EvaluationDomain<C::Scalar>, 51 | fixed_commitments: Vec<C>, | ^^^^^^^^^^^^^^^^^ 52 | permutation: permutation::VerifyingKey<C>, | ^^^^^^^^^^^ | = note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: unused variable: `advice_column` --> halo2_proofs/src/plonk/prover.rs:337:28 | 337 | for (column_index, advice_column) in witness.iter().enumerate() { | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_advice_column` | = note: `#[warn(unused_variables)]` on by default

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/