Skip to content

fix: Make multicore work + fix wasm compilation issues in CI #272

fix: Make multicore work + fix wasm compilation issues in CI

fix: Make multicore work + fix wasm compilation issues in CI #272

Triggered via push January 4, 2024 15:51
Status Success
Total duration 2m 37s
Artifacts

lints-beta.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

169 warnings
variables can be used directly in the `format!` string: halo2_proofs/src/dev.rs#L1201
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev.rs:1201:17 | 1201 | panic!("invalid gate row id {}", row_id); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 1201 - panic!("invalid gate row id {}", row_id); 1201 + panic!("invalid gate row id {row_id}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev.rs#L1196
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev.rs:1196:17 | 1196 | panic!("invalid gate row id {}", row_id); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 1196 - panic!("invalid gate row id {}", row_id); 1196 + panic!("invalid gate row id {row_id}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev.rs#L758
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev.rs:758:17 | 758 | panic!("invalid lookup row id {}", row_id) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 758 - panic!("invalid lookup row id {}", row_id) 758 + panic!("invalid lookup row id {row_id}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev.rs#L753
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev.rs:753:17 | 753 | panic!("invalid gate row id {}", row_id) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 753 - panic!("invalid gate row id {}", row_id) 753 + panic!("invalid gate row id {row_id}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/graph.rs#L39
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/graph.rs:39:17 | 39 | format!("[{}] {}", gadget_name, name) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 39 - format!("[{}] {}", gadget_name, name) 39 + format!("[{gadget_name}] {name}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/graph/layout.rs#L315
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/graph/layout.rs:315:25 | 315 | format!("{} usable rows", usable_rows), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 315 - format!("{} usable rows", usable_rows), 315 + format!("{usable_rows} usable rows"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L267
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:267:13 | 267 | write!(w, "{},", query).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 267 - write!(w, "{},", query).unwrap(); 267 + write!(w, "{query},").unwrap(); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L165
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:165:49 | 165 | ... (true, true) => format!("({}) * ({})", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 165 - (true, true) => format!("({}) * ({})", a, b), 165 + (true, true) => format!("({a}) * ({b})"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L164
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:164:50 | 164 | ... (true, false) => format!("({}) * {}", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 164 - (true, false) => format!("({}) * {}", a, b), 164 + (true, false) => format!("({a}) * {b}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L163
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:163:50 | 163 | ... (false, true) => format!("{} * ({})", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 163 - (false, true) => format!("{} * ({})", a, b), 163 + (false, true) => format!("{a} * ({b})"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L162
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:162:51 | 162 | ... (false, false) => format!("{} * {}", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 162 - (false, false) => format!("{} * {}", a, b), 162 + (false, false) => format!("{a} * {b}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L158
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:158:37 | 158 | ... format!("{} + {}", a, b) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 158 - format!("{} + {}", a, b) 158 + format!("{a} + {b}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L156
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:156:37 | 156 | ... format!("{} - {}", a, b) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 156 - format!("{} - {}", a, b) 156 + format!("{a} - {b}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L151
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:151:37 | 151 | ... format!("-{}", a) | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 151 - format!("-{}", a) 151 + format!("-{a}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L149
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:149:37 | 149 | ... format!("-({})", a) | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 149 - format!("-({})", a) 149 + format!("-({a})") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L874
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:874:18 | 874 | _ => eprintln!("{}", self), | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 874 - _ => eprintln!("{}", self), 874 + _ => eprintln!("{self}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L834
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:834:13 | 834 | eprintln!(" | x{} = {}", i, value); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 834 - eprintln!(" | x{} = {}", i, value); 834 + eprintln!(" | x{i} = {value}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L826
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:826:17 | 826 | eprint!(" <--{{ Shuffle '{}' inputs queried here", name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 826 - eprint!(" <--{{ Shuffle '{}' inputs queried here", name); 826 + eprint!(" <--{{ Shuffle '{name}' inputs queried here"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L811
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:811:28 | 811 | .or_insert(format!("x{}", i)); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 811 - .or_insert(format!("x{}", i)); 811 + .or_insert(format!("x{i}")); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L772
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:772:5 | 772 | eprintln!(" Shuffle '{}' inputs:", name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 772 - eprintln!(" Shuffle '{}' inputs:", name); 772 + eprintln!(" Shuffle '{name}' inputs:"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L734
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:734:21 | 734 | &|a, b| format! {"{} * {:?}", a, b}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 734 - &|a, b| format! {"{} * {:?}", a, b}, 734 + &|a, b| format! {"{a} * {b:?}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L733
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:733:21 | 733 | &|a, b| format! {"{} * {}", a,b}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 733 - &|a, b| format! {"{} * {}", a,b}, 733 + &|a, b| format! {"{a} * {b}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L732
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:732:21 | 732 | &|a, b| format! {"{} + {}", a,b}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 732 - &|a, b| format! {"{} + {}", a,b}, 732 + &|a, b| format! {"{a} + {b}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L731
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:731:22 | 731 | &|query| format! {"-{}", query}, | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 731 - &|query| format! {"-{}", query}, 731 + &|query| format! {"-{query}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L695
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:695:18 | 695 | &|f| format! {"Const: {:#?}", f}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 695 - &|f| format! {"Const: {:#?}", f}, 695 + &|f| format! {"Const: {f:#?}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L669
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:669:13 | 669 | eprintln!(" | x{} = {}", i, value); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 669 - eprintln!(" | x{} = {}", i, value); 669 + eprintln!(" | x{i} = {value}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L661
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:661:17 | 661 | eprint!(" <--{{ Lookup '{}' inputs queried here", name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 661 - eprint!(" <--{{ Lookup '{}' inputs queried here", name); 661 + eprint!(" <--{{ Lookup '{name}' inputs queried here"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L646
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:646:28 | 646 | .or_insert(format!("x{}", i)); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 646 - .or_insert(format!("x{}", i)); 646 + .or_insert(format!("x{i}")); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L607
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:607:5 | 607 | eprintln!(" Lookup '{}' inputs:", name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 607 - eprintln!(" Lookup '{}' inputs:", name); 607 + eprintln!(" Lookup '{name}' inputs:"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L568
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:568:21 | 568 | &|a, b| format! {"{} * {:?}", a, b}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 568 - &|a, b| format! {"{} * {:?}", a, b}, 568 + &|a, b| format! {"{a} * {b:?}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L567
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:567:21 | 567 | &|a, b| format! {"{} * {}", a,b}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 567 - &|a, b| format! {"{} * {}", a,b}, 567 + &|a, b| format! {"{a} * {b}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L566
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:566:21 | 566 | &|a, b| format! {"{} + {}", a,b}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 566 - &|a, b| format! {"{} + {}", a,b}, 566 + &|a, b| format! {"{a} + {b}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L565
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:565:22 | 565 | &|query| format! {"-{}", query}, | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 565 - &|query| format! {"-{}", query}, 565 + &|query| format! {"-{query}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L529
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:529:18 | 529 | &|f| format! {"Const: {:#?}", f}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 529 - &|f| format! {"Const: {:#?}", f}, 529 + &|f| format! {"Const: {f:#?}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L484
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:484:9 | 484 | eprintln!(" x{} = {}", i, value); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 484 - eprintln!(" x{} = {}", i, value); 484 + eprintln!(" x{i} = {value}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L459
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:459:24 | 459 | .or_insert(format!("x{}", i)); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 459 - .or_insert(format!("x{}", i)); 459 + .or_insert(format!("x{i}")); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L397
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:397:21 | 397 | format!("x{}", i) | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 397 - format!("x{}", i) 397 + format!("x{i}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L355
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:355:18 | 355 | _ => write!(f, "{:#}", self), | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 355 - _ => write!(f, "{:#}", self), 355 + _ => write!(f, "{self:#}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L353
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:353:17 | 353 | write!(f, "{:#?}", debug) | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 353 - write!(f, "{:#?}", debug) 353 + write!(f, "{debug:#?}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L298
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:298:17 | 298 | / write!( 299 | | f, 300 | | "Shuffle {}(index: {}) is not satisfied {}", 301 | | name, shuffle_index, location 302 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L287
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:287:17 | 287 | / write!( 288 | | f, 289 | | "Lookup {}(index: {}) is not satisfied {}", 290 | | name, lookup_index, location 291 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L276
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:276:17 | 276 | / write!( 277 | | f, 278 | | "{} is active on an unusable row - missing selector?", 279 | | constraint 280 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L271
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:271:21 | 271 | writeln!(f, "- {} = {}", dvc, value)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 271 - writeln!(f, "- {} = {}", dvc, value)?; 271 + writeln!(f, "- {dvc} = {value}")?; |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L260
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:260:17 | 260 | writeln!(f, "{} is not satisfied {}", constraint, location)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 260 - writeln!(f, "{} is not satisfied {}", constraint, location)?; 260 + writeln!(f, "{constraint} is not satisfied {location}")?; |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L249
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:249:17 | 249 | / write!( 250 | | f, 251 | | "{} uses {} at offset {}, which requires cell in instance column {:?} at row {} to be assigned.", 252 | | region, gate, gate_offset, column, row 253 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L44
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:44:17 | 44 | write!(f, "outside any region, on row {}", row) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 44 - write!(f, "outside any region, on row {}", row) 44 + write!(f, "outside any region, on row {row}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L42
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:42:50 | 42 | Self::InRegion { region, offset } => write!(f, "in {} at offset {}", region, offset), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 42 - Self::InRegion { region, offset } => write!(f, "in {} at offset {}", region, offset), 42 + Self::InRegion { region, offset } => write!(f, "in {region} at offset {offset}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L204
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:204:29 | 204 | (true, true) => format!("({}) * ({})", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 204 - (true, true) => format!("({}) * ({})", a, b), 204 + (true, true) => format!("({a}) * ({b})"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L203
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:203:30 | 203 | (true, false) => format!("({}) * {}", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 203 - (true, false) => format!("({}) * {}", a, b), 203 + (true, false) => format!("({a}) * {b}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L202
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:202:30 | 202 | (false, true) => format!("{} * ({})", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 202 - (false, true) => format!("{} * ({})", a, b), 202 + (false, true) => format!("{a} * ({b})"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L201
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:201:31 | 201 | (false, false) => format!("{} * {}", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 201 - (false, false) => format!("{} * {}", a, b), 201 + (false, false) => format!("{a} * {b}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L197
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:197:17 | 197 | format!("{} + {}", a, b) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 197 - format!("{} + {}", a, b) 197 + format!("{a} + {b}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L195
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:195:17 | 195 | format!("{} - {}", a, b) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 195 - format!("{} - {}", a, b) 195 + format!("{a} - {b}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L190
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:190:17 | 190 | format!("-{}", a) | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 190 - format!("-{}", a) 190 + format!("-{a}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L188
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:188:17 | 188 | format!("-({})", a) | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 188 - format!("-({})", a) 188 + format!("-({a})") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L115
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:115:5 | 115 | eprint!("{} +--------+", prefix); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 115 - eprint!("{} +--------+", prefix); 115 + eprint!("{prefix} +--------+"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L65
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:65:5 | 65 | eprint!("\n{}", col_headers); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 65 - eprint!("\n{}", col_headers); 65 + eprint!("\n{col_headers}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L61
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:61:34 | 61 | col_headers.push_str(format!("{} |Rotation|", prefix).as_str()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 61 - col_headers.push_str(format!("{} |Rotation|", prefix).as_str()); 61 + col_headers.push_str(format!("{prefix} |Rotation|").as_str()); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L60
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:60:34 | 60 | col_headers.push_str(format!("{}Cell layout at row {}:\n", prefix, row).as_str()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 60 - col_headers.push_str(format!("{}Cell layout at row {}:\n", prefix, row).as_str()); 60 + col_headers.push_str(format!("{prefix}Cell layout at row {row}:\n").as_str()); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L56
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:56:34 | 56 | col_headers.push_str(format!("{} | Offset |", prefix).as_str()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 56 - col_headers.push_str(format!("{} | Offset |", prefix).as_str()); 56 + col_headers.push_str(format!("{prefix} | Offset |").as_str()); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/util.rs#L70
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/util.rs:70:9 | 70 | format!("0x{}", s) | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 70 - format!("0x{}", s) 70 + format!("0x{s}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/util.rs#L66
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/util.rs:66:17 | 66 | let s = format!("{:?}", v); | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 66 - let s = format!("{:?}", v); 66 + let s = format!("{v:?}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L130
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:130:17 | 130 | / write!( 131 | | f, 132 | | "Attempted to overwrite default value {} with {} in {:?}", 133 | | default, val, col 134 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L127
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:127:17 | 127 | write!(f, "{:?} has already been used", col) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 127 - write!(f, "{:?} has already been used", col) 127 + write!(f, "{col:?} has already been used") |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L121
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:121:84 | 121 | TableError::UnevenColumnLengths((col, col_len), (table, table_len)) => write!( | ____________________________________________________________________________________^ 122 | | f, 123 | | "{:?} has length {} while {:?} has length {}", 124 | | col, col_len, table, table_len 125 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L115
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:115:17 | 115 | / write!( 116 | | f, 117 | | "{:?} not fully assigned. Help: assign a value at offset 0.", 118 | | col 119 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L84
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:84:41 | 84 | Error::TableError(error) => write!(f, "{}", error) | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 84 - Error::TableError(error) => write!(f, "{}", error) 84 + Error::TableError(error) => write!(f, "{error}") |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L79
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:79:54 | 79 | Error::ColumnNotInPermutation(column) => write!( | ______________________________________________________^ 80 | | f, 81 | | "Column {:?} must be included in the permutation. Help: try applying `meta.enable_equalty` on the column", 82 | | column 83 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L67
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:67:60 | 67 | Error::NotEnoughRowsAvailable { current_k } => write!( | ____________________________________________________________^ 68 | | f, 69 | | "k = {} is too small for the given circuit. Try using a larger value of k", 70 | | current_k, 71 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L66
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:66:37 | 66 | Error::Transcript(e) => write!(f, "Transcript error: {}", e), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 66 - Error::Transcript(e) => write!(f, "Transcript error: {}", e), 66 + Error::Transcript(e) => write!(f, "Transcript error: {e}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L2287
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:2287:17 | 2287 | / panic!( 2288 | | "No Column<Advice> is used in phase {:?} while allocating a new {:?}", 2289 | | phase, resource 2290 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L2267
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:2267:13 | 2267 | format!("Challenge usable after phase {:?}", phase).as_str(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 2267 - format!("Challenge usable after phase {:?}", phase).as_str(), 2267 + format!("Challenge usable after phase {phase:?}").as_str(), |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L2234
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:2234:17 | 2234 | format!("Column<Advice> in later phase {:?}", phase).as_str(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 2234 - format!("Column<Advice> in later phase {:?}", phase).as_str(), 2234 + format!("Column<Advice> in later phase {phase:?}").as_str(), |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L2209
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:2209:17 | 2209 | format!("Column<Advice> in later phase {:?}", phase).as_str(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 2209 - format!("Column<Advice> in later phase {:?}", phase).as_str(), 2209 + format!("Column<Advice> in later phase {phase:?}").as_str(), |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L1160
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:1160:17 | 1160 | write!(writer, "*{:?}", f) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 1160 - write!(writer, "*{:?}", f) 1160 + write!(writer, "*{f:?}") |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L1113
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:1113:45 | 1113 | Expression::Constant(scalar) => write!(writer, "{:?}", scalar), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 1113 - Expression::Constant(scalar) => write!(writer, "{:?}", scalar), 1113 + Expression::Constant(scalar) => write!(writer, "{scalar:?}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/circuit.rs#L575
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/circuit.rs:575:68 | 575 | ... gadget_name = symbol.name().map(|name| format!("{:#}", name)); | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 575 - gadget_name = symbol.name().map(|name| format!("{:#}", name)); 575 + gadget_name = symbol.name().map(|name| format!("{name:#}")); |
variables can be used directly in the `format!` string: halo2_proofs/src/circuit/table_layouter.rs#L106
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/circuit/table_layouter.rs:106:21 | 106 | format!("{:?}", value), | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all` help: change this to | 106 - format!("{:?}", value), 106 + format!("{value:?}"), |
variables can be used directly in the `format!` string: halo2_proofs/benches/dev_lookup.rs#L82
warning: variables can be used directly in the `format!` string --> halo2_proofs/benches/dev_lookup.rs:82:32 | 82 | ... || format!("offset {}", offset), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 82 - || format!("offset {}", offset), 82 + || format!("offset {offset}"), |
variables can be used directly in the `format!` string: halo2_proofs/benches/dev_lookup.rs#L65
warning: variables can be used directly in the `format!` string --> halo2_proofs/benches/dev_lookup.rs:65:32 | 65 | ... || format!("row {}", row), | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all` help: change this to | 65 - || format!("row {}", row), 65 + || format!("row {row}"), |
variables can be used directly in the `format!` string: halo2_proofs/tests/plonk_api.rs#L494
warning: variables can be used directly in the `format!` string --> halo2_proofs/tests/plonk_api.rs:494:23 | 494 | Err(e) => panic!("{:?}", e), | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all` help: change this to | 494 - Err(e) => panic!("{:?}", e), 494 + Err(e) => panic!("{e:?}"), |
variables can be used directly in the `format!` string: halo2_proofs/examples/cost-model.rs#L298
warning: variables can be used directly in the `format!` string --> halo2_proofs/examples/cost-model.rs:298:5 | 298 | println!("{:#?}", c); | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all` help: change this to | 298 - println!("{:#?}", c); 298 + println!("{c:#?}"); |
variables can be used directly in the `format!` string: halo2_proofs/examples/shuffle.rs#L237
warning: variables can be used directly in the `format!` string --> halo2_proofs/examples/shuffle.rs:237:28 | 237 | || format!("z[{}]", offset), | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 237 - || format!("z[{}]", offset), 237 + || format!("z[{offset}]"), |
variables can be used directly in the `format!` string: halo2_proofs/examples/shuffle.rs#L186
warning: variables can be used directly in the `format!` string --> halo2_proofs/examples/shuffle.rs:186:32 | 186 | ... || format!("shuffled[{}][{}]", idx, offset), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 186 - || format!("shuffled[{}][{}]", idx, offset), 186 + || format!("shuffled[{idx}][{offset}]"), |
variables can be used directly in the `format!` string: halo2_proofs/examples/shuffle.rs#L171
warning: variables can be used directly in the `format!` string --> halo2_proofs/examples/shuffle.rs:171:32 | 171 | ... || format!("original[{}][{}]", idx, offset), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all` help: change this to | 171 - || format!("original[{}][{}]", idx, offset), 171 + || format!("original[{idx}][{offset}]"), |
variables can be used directly in the `format!` string: halo2_proofs/examples/circuit-layout.rs#L248
warning: variables can be used directly in the `format!` string --> halo2_proofs/examples/circuit-layout.rs:248:20 | 248 | || format!("region_{}", i), | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all` help: change this to | 248 - || format!("region_{}", i), 248 + || format!("region_{i}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev.rs#L1201
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev.rs:1201:17 | 1201 | panic!("invalid gate row id {}", row_id); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 1201 - panic!("invalid gate row id {}", row_id); 1201 + panic!("invalid gate row id {row_id}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev.rs#L1196
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev.rs:1196:17 | 1196 | panic!("invalid gate row id {}", row_id); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 1196 - panic!("invalid gate row id {}", row_id); 1196 + panic!("invalid gate row id {row_id}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev.rs#L758
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev.rs:758:17 | 758 | panic!("invalid lookup row id {}", row_id) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 758 - panic!("invalid lookup row id {}", row_id) 758 + panic!("invalid lookup row id {row_id}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev.rs#L753
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev.rs:753:17 | 753 | panic!("invalid gate row id {}", row_id) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 753 - panic!("invalid gate row id {}", row_id) 753 + panic!("invalid gate row id {row_id}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/graph.rs#L39
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/graph.rs:39:17 | 39 | format!("[{}] {}", gadget_name, name) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 39 - format!("[{}] {}", gadget_name, name) 39 + format!("[{gadget_name}] {name}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/graph/layout.rs#L315
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/graph/layout.rs:315:25 | 315 | format!("{} usable rows", usable_rows), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 315 - format!("{} usable rows", usable_rows), 315 + format!("{usable_rows} usable rows"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L267
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:267:13 | 267 | write!(w, "{},", query).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 267 - write!(w, "{},", query).unwrap(); 267 + write!(w, "{query},").unwrap(); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L165
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:165:49 | 165 | ... (true, true) => format!("({}) * ({})", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 165 - (true, true) => format!("({}) * ({})", a, b), 165 + (true, true) => format!("({a}) * ({b})"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L164
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:164:50 | 164 | ... (true, false) => format!("({}) * {}", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 164 - (true, false) => format!("({}) * {}", a, b), 164 + (true, false) => format!("({a}) * {b}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L163
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:163:50 | 163 | ... (false, true) => format!("{} * ({})", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 163 - (false, true) => format!("{} * ({})", a, b), 163 + (false, true) => format!("{a} * ({b})"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L162
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:162:51 | 162 | ... (false, false) => format!("{} * {}", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 162 - (false, false) => format!("{} * {}", a, b), 162 + (false, false) => format!("{a} * {b}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L158
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:158:37 | 158 | ... format!("{} + {}", a, b) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 158 - format!("{} + {}", a, b) 158 + format!("{a} + {b}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L156
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:156:37 | 156 | ... format!("{} - {}", a, b) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 156 - format!("{} - {}", a, b) 156 + format!("{a} - {b}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L151
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:151:37 | 151 | ... format!("-{}", a) | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 151 - format!("-{}", a) 151 + format!("-{a}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/gates.rs#L149
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/gates.rs:149:37 | 149 | ... format!("-({})", a) | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 149 - format!("-({})", a) 149 + format!("-({a})") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L874
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:874:18 | 874 | _ => eprintln!("{}", self), | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 874 - _ => eprintln!("{}", self), 874 + _ => eprintln!("{self}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L834
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:834:13 | 834 | eprintln!(" | x{} = {}", i, value); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 834 - eprintln!(" | x{} = {}", i, value); 834 + eprintln!(" | x{i} = {value}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L826
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:826:17 | 826 | eprint!(" <--{{ Shuffle '{}' inputs queried here", name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 826 - eprint!(" <--{{ Shuffle '{}' inputs queried here", name); 826 + eprint!(" <--{{ Shuffle '{name}' inputs queried here"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L811
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:811:28 | 811 | .or_insert(format!("x{}", i)); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 811 - .or_insert(format!("x{}", i)); 811 + .or_insert(format!("x{i}")); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L772
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:772:5 | 772 | eprintln!(" Shuffle '{}' inputs:", name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 772 - eprintln!(" Shuffle '{}' inputs:", name); 772 + eprintln!(" Shuffle '{name}' inputs:"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L734
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:734:21 | 734 | &|a, b| format! {"{} * {:?}", a, b}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 734 - &|a, b| format! {"{} * {:?}", a, b}, 734 + &|a, b| format! {"{a} * {b:?}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L733
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:733:21 | 733 | &|a, b| format! {"{} * {}", a,b}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 733 - &|a, b| format! {"{} * {}", a,b}, 733 + &|a, b| format! {"{a} * {b}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L732
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:732:21 | 732 | &|a, b| format! {"{} + {}", a,b}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 732 - &|a, b| format! {"{} + {}", a,b}, 732 + &|a, b| format! {"{a} + {b}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L731
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:731:22 | 731 | &|query| format! {"-{}", query}, | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 731 - &|query| format! {"-{}", query}, 731 + &|query| format! {"-{query}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L695
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:695:18 | 695 | &|f| format! {"Const: {:#?}", f}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 695 - &|f| format! {"Const: {:#?}", f}, 695 + &|f| format! {"Const: {f:#?}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L669
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:669:13 | 669 | eprintln!(" | x{} = {}", i, value); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 669 - eprintln!(" | x{} = {}", i, value); 669 + eprintln!(" | x{i} = {value}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L661
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:661:17 | 661 | eprint!(" <--{{ Lookup '{}' inputs queried here", name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 661 - eprint!(" <--{{ Lookup '{}' inputs queried here", name); 661 + eprint!(" <--{{ Lookup '{name}' inputs queried here"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L646
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:646:28 | 646 | .or_insert(format!("x{}", i)); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 646 - .or_insert(format!("x{}", i)); 646 + .or_insert(format!("x{i}")); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L607
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:607:5 | 607 | eprintln!(" Lookup '{}' inputs:", name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 607 - eprintln!(" Lookup '{}' inputs:", name); 607 + eprintln!(" Lookup '{name}' inputs:"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L568
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:568:21 | 568 | &|a, b| format! {"{} * {:?}", a, b}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 568 - &|a, b| format! {"{} * {:?}", a, b}, 568 + &|a, b| format! {"{a} * {b:?}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L567
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:567:21 | 567 | &|a, b| format! {"{} * {}", a,b}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 567 - &|a, b| format! {"{} * {}", a,b}, 567 + &|a, b| format! {"{a} * {b}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L566
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:566:21 | 566 | &|a, b| format! {"{} + {}", a,b}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 566 - &|a, b| format! {"{} + {}", a,b}, 566 + &|a, b| format! {"{a} + {b}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L565
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:565:22 | 565 | &|query| format! {"-{}", query}, | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 565 - &|query| format! {"-{}", query}, 565 + &|query| format! {"-{query}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L529
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:529:18 | 529 | &|f| format! {"Const: {:#?}", f}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 529 - &|f| format! {"Const: {:#?}", f}, 529 + &|f| format! {"Const: {f:#?}"}, |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L484
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:484:9 | 484 | eprintln!(" x{} = {}", i, value); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 484 - eprintln!(" x{} = {}", i, value); 484 + eprintln!(" x{i} = {value}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L459
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:459:24 | 459 | .or_insert(format!("x{}", i)); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 459 - .or_insert(format!("x{}", i)); 459 + .or_insert(format!("x{i}")); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L397
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:397:21 | 397 | format!("x{}", i) | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 397 - format!("x{}", i) 397 + format!("x{i}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L355
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:355:18 | 355 | _ => write!(f, "{:#}", self), | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 355 - _ => write!(f, "{:#}", self), 355 + _ => write!(f, "{self:#}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L353
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:353:17 | 353 | write!(f, "{:#?}", debug) | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 353 - write!(f, "{:#?}", debug) 353 + write!(f, "{debug:#?}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L298
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:298:17 | 298 | / write!( 299 | | f, 300 | | "Shuffle {}(index: {}) is not satisfied {}", 301 | | name, shuffle_index, location 302 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L287
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:287:17 | 287 | / write!( 288 | | f, 289 | | "Lookup {}(index: {}) is not satisfied {}", 290 | | name, lookup_index, location 291 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L276
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:276:17 | 276 | / write!( 277 | | f, 278 | | "{} is active on an unusable row - missing selector?", 279 | | constraint 280 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L271
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:271:21 | 271 | writeln!(f, "- {} = {}", dvc, value)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 271 - writeln!(f, "- {} = {}", dvc, value)?; 271 + writeln!(f, "- {dvc} = {value}")?; |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L260
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:260:17 | 260 | writeln!(f, "{} is not satisfied {}", constraint, location)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 260 - writeln!(f, "{} is not satisfied {}", constraint, location)?; 260 + writeln!(f, "{constraint} is not satisfied {location}")?; |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L249
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:249:17 | 249 | / write!( 250 | | f, 251 | | "{} uses {} at offset {}, which requires cell in instance column {:?} at row {} to be assigned.", 252 | | region, gate, gate_offset, column, row 253 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L44
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:44:17 | 44 | write!(f, "outside any region, on row {}", row) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 44 - write!(f, "outside any region, on row {}", row) 44 + write!(f, "outside any region, on row {row}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure.rs#L42
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure.rs:42:50 | 42 | Self::InRegion { region, offset } => write!(f, "in {} at offset {}", region, offset), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 42 - Self::InRegion { region, offset } => write!(f, "in {} at offset {}", region, offset), 42 + Self::InRegion { region, offset } => write!(f, "in {region} at offset {offset}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L204
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:204:29 | 204 | (true, true) => format!("({}) * ({})", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 204 - (true, true) => format!("({}) * ({})", a, b), 204 + (true, true) => format!("({a}) * ({b})"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L203
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:203:30 | 203 | (true, false) => format!("({}) * {}", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 203 - (true, false) => format!("({}) * {}", a, b), 203 + (true, false) => format!("({a}) * {b}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L202
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:202:30 | 202 | (false, true) => format!("{} * ({})", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 202 - (false, true) => format!("{} * ({})", a, b), 202 + (false, true) => format!("{a} * ({b})"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L201
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:201:31 | 201 | (false, false) => format!("{} * {}", a, b), | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 201 - (false, false) => format!("{} * {}", a, b), 201 + (false, false) => format!("{a} * {b}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L197
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:197:17 | 197 | format!("{} + {}", a, b) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 197 - format!("{} + {}", a, b) 197 + format!("{a} + {b}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L195
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:195:17 | 195 | format!("{} - {}", a, b) | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 195 - format!("{} - {}", a, b) 195 + format!("{a} - {b}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L190
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:190:17 | 190 | format!("-{}", a) | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 190 - format!("-{}", a) 190 + format!("-{a}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L188
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:188:17 | 188 | format!("-({})", a) | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 188 - format!("-({})", a) 188 + format!("-({a})") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L115
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:115:5 | 115 | eprint!("{} +--------+", prefix); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 115 - eprint!("{} +--------+", prefix); 115 + eprint!("{prefix} +--------+"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L65
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:65:5 | 65 | eprint!("\n{}", col_headers); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 65 - eprint!("\n{}", col_headers); 65 + eprint!("\n{col_headers}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L61
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:61:34 | 61 | col_headers.push_str(format!("{} |Rotation|", prefix).as_str()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 61 - col_headers.push_str(format!("{} |Rotation|", prefix).as_str()); 61 + col_headers.push_str(format!("{prefix} |Rotation|").as_str()); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L60
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:60:34 | 60 | col_headers.push_str(format!("{}Cell layout at row {}:\n", prefix, row).as_str()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 60 - col_headers.push_str(format!("{}Cell layout at row {}:\n", prefix, row).as_str()); 60 + col_headers.push_str(format!("{prefix}Cell layout at row {row}:\n").as_str()); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/failure/emitter.rs#L56
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/failure/emitter.rs:56:34 | 56 | col_headers.push_str(format!("{} | Offset |", prefix).as_str()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 56 - col_headers.push_str(format!("{} | Offset |", prefix).as_str()); 56 + col_headers.push_str(format!("{prefix} | Offset |").as_str()); |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/util.rs#L70
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/util.rs:70:9 | 70 | format!("0x{}", s) | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 70 - format!("0x{}", s) 70 + format!("0x{s}") |
variables can be used directly in the `format!` string: halo2_proofs/src/dev/util.rs#L66
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/dev/util.rs:66:17 | 66 | let s = format!("{:?}", v); | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 66 - let s = format!("{:?}", v); 66 + let s = format!("{v:?}"); |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L130
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:130:17 | 130 | / write!( 131 | | f, 132 | | "Attempted to overwrite default value {} with {} in {:?}", 133 | | default, val, col 134 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L127
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:127:17 | 127 | write!(f, "{:?} has already been used", col) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 127 - write!(f, "{:?} has already been used", col) 127 + write!(f, "{col:?} has already been used") |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L121
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:121:84 | 121 | TableError::UnevenColumnLengths((col, col_len), (table, table_len)) => write!( | ____________________________________________________________________________________^ 122 | | f, 123 | | "{:?} has length {} while {:?} has length {}", 124 | | col, col_len, table, table_len 125 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L115
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:115:17 | 115 | / write!( 116 | | f, 117 | | "{:?} not fully assigned. Help: assign a value at offset 0.", 118 | | col 119 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L84
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:84:41 | 84 | Error::TableError(error) => write!(f, "{}", error) | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 84 - Error::TableError(error) => write!(f, "{}", error) 84 + Error::TableError(error) => write!(f, "{error}") |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L79
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:79:54 | 79 | Error::ColumnNotInPermutation(column) => write!( | ______________________________________________________^ 80 | | f, 81 | | "Column {:?} must be included in the permutation. Help: try applying `meta.enable_equalty` on the column", 82 | | column 83 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L67
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:67:60 | 67 | Error::NotEnoughRowsAvailable { current_k } => write!( | ____________________________________________________________^ 68 | | f, 69 | | "k = {} is too small for the given circuit. Try using a larger value of k", 70 | | current_k, 71 | | ), | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/error.rs#L66
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/error.rs:66:37 | 66 | Error::Transcript(e) => write!(f, "Transcript error: {}", e), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 66 - Error::Transcript(e) => write!(f, "Transcript error: {}", e), 66 + Error::Transcript(e) => write!(f, "Transcript error: {e}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L2287
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:2287:17 | 2287 | / panic!( 2288 | | "No Column<Advice> is used in phase {:?} while allocating a new {:?}", 2289 | | phase, resource 2290 | | ) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L2267
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:2267:13 | 2267 | format!("Challenge usable after phase {:?}", phase).as_str(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 2267 - format!("Challenge usable after phase {:?}", phase).as_str(), 2267 + format!("Challenge usable after phase {phase:?}").as_str(), |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L2234
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:2234:17 | 2234 | format!("Column<Advice> in later phase {:?}", phase).as_str(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 2234 - format!("Column<Advice> in later phase {:?}", phase).as_str(), 2234 + format!("Column<Advice> in later phase {phase:?}").as_str(), |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L2209
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:2209:17 | 2209 | format!("Column<Advice> in later phase {:?}", phase).as_str(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 2209 - format!("Column<Advice> in later phase {:?}", phase).as_str(), 2209 + format!("Column<Advice> in later phase {phase:?}").as_str(), |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L1160
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:1160:17 | 1160 | write!(writer, "*{:?}", f) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 1160 - write!(writer, "*{:?}", f) 1160 + write!(writer, "*{f:?}") |
variables can be used directly in the `format!` string: halo2_proofs/src/plonk/circuit.rs#L1113
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/plonk/circuit.rs:1113:45 | 1113 | Expression::Constant(scalar) => write!(writer, "{:?}", scalar), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 1113 - Expression::Constant(scalar) => write!(writer, "{:?}", scalar), 1113 + Expression::Constant(scalar) => write!(writer, "{scalar:?}"), |
variables can be used directly in the `format!` string: halo2_proofs/src/circuit.rs#L575
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/circuit.rs:575:68 | 575 | ... gadget_name = symbol.name().map(|name| format!("{:#}", name)); | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 575 - gadget_name = symbol.name().map(|name| format!("{:#}", name)); 575 + gadget_name = symbol.name().map(|name| format!("{name:#}")); |
variables can be used directly in the `format!` string: halo2_proofs/src/circuit/table_layouter.rs#L106
warning: variables can be used directly in the `format!` string --> halo2_proofs/src/circuit/table_layouter.rs:106:21 | 106 | format!("{:?}", value), | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all` help: change this to | 106 - format!("{:?}", value), 106 + format!("{value:?}"), |
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/