feat(maci-signup): implement signup with MACI and EAS #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
force-pushed
the
feat/maci-signup
branch
from
9e6715a to
7008076
Compare
samajammin
reviewed
Feb 6, 2024
| @@ -112,6 +112,8 @@ NEXT_PUBLIC_METADATA_SCHEMA=0xd00c966351896bd3dc37d22017bf1ef23165f859d7546a2aba | |||
| NEXT_PUBLIC_EAS_CONTRACT_ADDRESS=0x4200000000000000000000000000000000000021 | |||
| NEXT_PUBLIC_EAS_SCHEMA_REGISTRY_ADDRESS=0x4200000000000000000000000000000000000020 | |||
|
|
|||
| # The address of a deployed MACI instance | |||
| NEXT_MACI_ADDRESS="" | |||
There was a problem hiding this comment.
Should this also be added to env.js?
There was a problem hiding this comment.
Not necessary, but recommended, because it can verify if it's configured correctly before running the app via a Zod schema. For example:
NEXT_PUBLIC_ADMIN_ADDRESSES: z.string().startsWith("0x"),
carlbarrdahl
reviewed
Feb 6, 2024
Comment on lines
+34
to
+35
| const schema = eas.schemas.badgeholder; | ||
| const attester = eas.schemas.badgeholderAttester; |
There was a problem hiding this comment.
Badgeholder is the same as voter.
To verify if an address is an approved voter, you can use:
const { data: isApproved } = useApprovedVoter(address);
// and on server-side
const isApproved = await fetchApprovedVoter(address);
|
I imagine this can be closed out @0xmad @kittybest ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4
Implement Signup with MACI and EAS