Merge pull request #1205 from privacy-scaling-explorations/chore/circ…

…uits-cleanup chore(circuits): remove todo messages
privacy-scaling-explorations · Feb 19, 2024 · f7efc8a · f7efc8a
2 parents d4d786d + 071acc4
commit f7efc8a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/circuits/circom/messageValidator.circom b/circuits/circom/messageValidator.circom
@@ -19,7 +19,6 @@ template MessageValidator() {
     validStateLeafIndex.in[0] <== stateTreeIndex;
     validStateLeafIndex.in[1] <== numSignUps;
 
-    // @todo check if we need this if we do the check inside processOne 
     // b) Whether the max vote option tree index is correct
     signal input voteOptionIndex;
     signal input maxVoteOptions;

diff --git a/circuits/circom/processMessages.circom b/circuits/circom/processMessages.circom
@@ -619,8 +619,6 @@ template ProcessOne(stateTreeDepth, voteOptionTreeDepth) {
     validVoteOptionIndex.in[1] <== maxVoteOptions;
 
     // @note pick the correct vote option index based on whether the index is < max vote options 
-    // @todo can probably add one output to messageValidator and take from there
-    // or maybe we can remove altogther from messageValidator so we don't double check this
     component cmdVoteOptionIndexMux = Mux1();
     cmdVoteOptionIndexMux.s <== validVoteOptionIndex.out;
     cmdVoteOptionIndexMux.c[0] <== 0;

diff --git a/circuits/circom/processMessagesNonQv.circom b/circuits/circom/processMessagesNonQv.circom
@@ -541,8 +541,6 @@ template ProcessOneNonQv(stateTreeDepth, voteOptionTreeDepth) {
     validVoteOptionIndex.in[1] <== maxVoteOptions;
 
     // @note pick the correct vote option index based on whether the index is < max vote options 
-    // @todo can probably add one output to messageValidator and take from there
-    // or maybe we can remove altogther from messageValidator so we don't double check this
     component cmdVoteOptionIndexMux = Mux1();
     cmdVoteOptionIndexMux.s <== validVoteOptionIndex.out;
     cmdVoteOptionIndexMux.c[0] <== 0;