Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pnpm migration #1005

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jan 11, 2024

Description

  • Migrate docs
  • Migrate workflows
  • Migrate scripts

Additional Notes

This PR should be merge into #987

Related issue(s)

Related to #793

Confirmation

@0xmad 0xmad added dependencies Pull requests that update a dependency file devops A DevOps related task chore Chore tasks labels Jan 11, 2024
@0xmad 0xmad added this to the MACI v1.1.1 refactor milestone Jan 11, 2024
@0xmad 0xmad self-assigned this Jan 11, 2024
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/lerna-8.0.2 branch from 7dcf456 to 5c1801c Compare January 11, 2024 19:55
@0xmad 0xmad force-pushed the chore/pnpm branch 2 times, most recently from 190892d to eac9e31 Compare January 11, 2024 19:59
@0xmad 0xmad marked this pull request as ready for review January 11, 2024 20:04
- [x] Migrate docs
- [x] Migrate workflows
- [x] Migrate scripts
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left one comment regarding the workspace import syntax

circuits/package.json Outdated Show resolved Hide resolved
@0xmad 0xmad requested a review from ctrlc03 January 11, 2024 20:25
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@0xmad 0xmad merged commit 54df724 into dependabot/npm_and_yarn/dev/lerna-8.0.2 Jan 11, 2024
14 checks passed
@0xmad 0xmad deleted the chore/pnpm branch January 11, 2024 21:03
@samajammin samajammin mentioned this pull request Jan 14, 2024
3 tasks
@samajammin
Copy link
Member

Nice @0xmad - excited to have this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks dependencies Pull requests that update a dependency file devops A DevOps related task
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants