Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable codeql and workflows cleanup #1007

Merged
merged 1 commit into from
Jan 11, 2024
Merged

chore: enable codeql and workflows cleanup #1007

merged 1 commit into from
Jan 11, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jan 11, 2024

Description

Add CodeQL boilerplate config and remove master branch from workflow files

Additional Notes

N/A

Related issue(s)

Related to #793

Confirmation

@0xmad 0xmad added devops A DevOps related task Security chore Chore tasks labels Jan 11, 2024
@0xmad 0xmad added this to the MACI v1.1.1 refactor milestone Jan 11, 2024
@0xmad 0xmad self-assigned this Jan 11, 2024
Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 37a735c
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65a069035d5d1b000812c1b1
😎 Deploy Preview https://deploy-preview-1007--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one question

.github/workflows/codeql.yml Show resolved Hide resolved
@ctrlc03 ctrlc03 self-requested a review January 11, 2024 22:21
@0xmad 0xmad marked this pull request as ready for review January 11, 2024 22:29
@0xmad 0xmad enabled auto-merge January 11, 2024 22:29
@0xmad 0xmad merged commit dcca295 into dev Jan 11, 2024
17 checks passed
@0xmad 0xmad deleted the chore/codeql branch January 11, 2024 22:31
@samajammin
Copy link
Member

Nice! 🎉

@samajammin
Copy link
Member

@0xmad
Copy link
Collaborator Author

0xmad commented Jan 15, 2024

So @0xmad does this workflow perform the same thing as the default setup? https://docs.github.com/en/code-security/code-scanning/enabling-code-scanning/configuring-default-setup-for-code-scanning

Yes, this one is a default config but with tweaks for our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks devops A DevOps related task Security
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants