Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): ensure we publish the correct files #1042

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 17, 2024

Description

Ensure we publish the correct files by setting the correct paths inside package.json

Confirmation

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit bc42724
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65a85912c74d90000819ef38
😎 Deploy Preview https://deploy-preview-1042--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 self-assigned this Jan 17, 2024
@ctrlc03 ctrlc03 force-pushed the fix/publishing-files branch from 55dc4b0 to a88e6e3 Compare January 17, 2024 22:27
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one question: do we need different files like license, changelog, readme for npm packages?

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 17, 2024

@ctrlc03 thanks, just one question: do we need different files like license, changelog, readme for npm packages?

yea think that would be good, I'll explicitly add them to files

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 17, 2024

@ctrlc03 thanks, just one question: do we need different files like license, changelog, readme for npm packages?

yea think that would be good, I'll explicitly add them to files

@0xmad seems like LICENSE gets added automatically from project root https://www.npmjs.com/package/maci-cli/v/0.0.0-ci.390bdc3?activeTab=code

@0xmad
Copy link
Collaborator

0xmad commented Jan 17, 2024

@ctrlc03 thanks, just one question: do we need different files like license, changelog, readme for npm packages?

yea think that would be good, I'll explicitly add them to files

@0xmad seems like LICENSE gets added automatically from project root https://www.npmjs.com/package/maci-cli/v/0.0.0-ci.390bdc3?activeTab=code

Ok, let's merge it then.

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 17, 2024

@ctrlc03 thanks, just one question: do we need different files like license, changelog, readme for npm packages?

yea think that would be good, I'll explicitly add them to files

@0xmad seems like LICENSE gets added automatically from project root https://www.npmjs.com/package/maci-cli/v/0.0.0-ci.390bdc3?activeTab=code

Ok, let's merge it then.

I'll add changelog too, can't hurt having it

@ctrlc03 ctrlc03 force-pushed the fix/publishing-files branch from a88e6e3 to bc42724 Compare January 17, 2024 22:47
@0xmad 0xmad enabled auto-merge January 17, 2024 23:01
@0xmad 0xmad merged commit ea97aa6 into dev Jan 17, 2024
17 checks passed
@0xmad 0xmad deleted the fix/publishing-files branch January 17, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants