Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): prioritize contract addresses params #1049

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 18, 2024

Description

Do no throw when the contract addresses file is not present but a contract address has been provided

Related issue(s)

fix #1039

Confirmation

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 8ec36c4
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65a94b08a90e1400088f94cf
😎 Deploy Preview https://deploy-preview-1049--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one comment to fix.

cli/ts/utils/storage.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the fix/cli-missing-contract-addr branch from 2847d5d to 6d0366b Compare January 18, 2024 15:59
do no throw when the contract addresses file is not present but a contract address has been provided

fix #1039
@ctrlc03 ctrlc03 force-pushed the fix/cli-missing-contract-addr branch from 6d0366b to 8ec36c4 Compare January 18, 2024 16:00
@ctrlc03 ctrlc03 requested a review from 0xmad January 18, 2024 16:00
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@0xmad 0xmad enabled auto-merge January 18, 2024 16:14
@0xmad 0xmad merged commit b5e9be9 into dev Jan 18, 2024
17 checks passed
@0xmad 0xmad deleted the fix/cli-missing-contract-addr branch January 18, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

mergeMessages error: "contractAddresses.json does not exist"
3 participants