test(benchmarks): add benchmarks for proof generation #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
force-pushed
the
test/benchmarks
branch
from
256fe63 to
e5acdc8
Compare
ctrlc03
force-pushed
the
test/benchmarks
branch
from
e5acdc8 to
ca102f5
Compare
0xmad
requested changes
Jan 22, 2024
|
|
||
| const NAME = "proof generation"; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/require-await |
There was a problem hiding this comment.
Why do you need to return promise if there is no await?
Comment on lines
90
to
110
| for (let i = 0; i < users.length; i += 1) { | ||
| const keypair = users[i]; | ||
| maciState.signUp(keypair.pubKey, voiceCreditBalance, BigInt(Date.now())); | ||
|
|
||
| // First command (valid) | ||
| const command = new PCommand( | ||
| BigInt(i) + 1n, | ||
| keypair.pubKey, | ||
| 5n, // voteOptionIndex, | ||
| 7n, // vote weight | ||
| 2n, // nonce | ||
| pollId, | ||
| ); | ||
|
|
||
| const signature = command.sign(keypair.privKey); | ||
|
|
||
| const ecdhKeypair = new Keypair(); | ||
| const sharedKey = Keypair.genEcdhSharedKey(ecdhKeypair.privKey, coordinatorKeypair.pubKey); | ||
| const message = command.encrypt(signature, sharedKey); | ||
| poll?.publishMessage(message, ecdhKeypair.pubKey); | ||
| } |
There was a problem hiding this comment.
Seems this one is duplicated too.
ctrlc03
force-pushed
the
test/benchmarks
branch
3 times, most recently
from
c3b1e4b to
80e9f6f
Compare
kittybest
reviewed
Jan 22, 2024
ctrlc03
force-pushed
the
test/benchmarks
branch
2 times, most recently
from
08a9886 to
fed3612
Compare
ctrlc03
force-pushed
the
test/benchmarks
branch
from
fed3612 to
6a5b353
Compare
|
Closing for now as most of the code is outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add benchmarks that compare how much time it takes to generate proofs for different number of signups and messages. Both using WASM and Rapidsnark with c witness gen.
Related issue(s)
Re: #1081
Confirmation