Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contract): add contract verification task #1122

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jan 29, 2024

Description

  • Update contract storage with already verified contracts
  • Fix deployment for poseidon contracts
  • Add contract verifier

Additional Notes

Verification doesn't work for Poseidon contracts

0x4B28230fcbe036470D6A11E8849533Cff279874E PoseidonT6: The contract you want to verify was compiled with solidity <0.4.7, but your configured compiler version is: 0.8.10.

Related issue(s)

Related to #1096

Confirmation

@0xmad 0xmad added the chore Chore tasks label Jan 29, 2024
@0xmad 0xmad self-assigned this Jan 29, 2024
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit ab4718f
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65b83a9a44b9c20008ea2deb
😎 Deploy Preview https://deploy-preview-1122--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xmad 0xmad force-pushed the chore/verification branch from f78b86c to 7d73447 Compare January 29, 2024 23:23
@0xmad 0xmad marked this pull request as ready for review January 29, 2024 23:40
@ctrlc03 ctrlc03 force-pushed the chore/verification branch from 7d73447 to 1e30471 Compare January 29, 2024 23:43
- [x] Update contract storage with already verified contracts
- [x] Fix deployment for poseidon contracts
- [x] Add contract verifier
@0xmad 0xmad force-pushed the chore/verification branch from 1e30471 to ab4718f Compare January 29, 2024 23:54
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@0xmad 0xmad enabled auto-merge January 29, 2024 23:54
@0xmad 0xmad merged commit 26b513c into dev Jan 30, 2024
19 checks passed
@0xmad 0xmad deleted the chore/verification branch January 30, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants