refactor(nonqv): optimize tally votes non qv circuit and contracts #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ctrlc03
force-pushed
the
refactor/tally-votes-non-qv
branch
from
1273880 to
9ef7e30
Compare
ctrlc03
force-pushed
the
refactor/tally-votes-non-qv
branch
from
9ef7e30 to
9060662
Compare
ctrlc03
requested review from
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
ctrlc03
force-pushed
the
refactor/tally-votes-non-qv
branch
2 times, most recently
from
1a2aa96 to
d60e452
Compare
|
There are some missing parts:
|
ctrlc03
force-pushed
the
refactor/tally-votes-non-qv
branch
from
d60e452 to
08ca900
Compare
Added! |
0xmad
reviewed
Feb 14, 2024
reduce the number of constraints for the tally votes non qv circuit, and amend the repo code to support the changes. This includes a new Tally contract with reduced logic which has been removed from the circuit.
ctrlc03
force-pushed
the
refactor/tally-votes-non-qv
branch
from
08ca900 to
ea632a9
Compare
0xmad
approved these changes
Feb 14, 2024
thanks for your patience with this review 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce the number of constraints for the
tallyVotesNonQvcircuit, and amend the repo code to support the changes. This includes a new Tally contract with reduced logic (no need for perVOSpentVoiceCredits anymore due to quadratic voting being removed).Relevant code to deploy either factory version of tally has been added, and as far as MACI is concerned, they implement the same interface so no changes were needed on the MACI contract.
With ceremony params (6,2,3) - from 398474 to 371675 constraints
Confirmation