fix(contracts): enforce msgType = 1 for vote messages at the contract level #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -163,7 +163,7 @@ | |||
| } | |||
|
|
|||
| /// @inheritdoc IPoll | |||
| function publishMessage(Message calldata _message, PubKey calldata _encPubKey) public virtual isWithinVotingDeadline { | |||
| function publishMessage(Message memory _message, PubKey calldata _encPubKey) public virtual isWithinVotingDeadline { | |||
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| @@ -163,7 +163,7 @@ | |||
| } | |||
|
|
|||
| /// @inheritdoc IPoll | |||
| function publishMessage(Message calldata _message, PubKey calldata _encPubKey) public virtual isWithinVotingDeadline { | |||
| function publishMessage(Message memory _message, PubKey calldata _encPubKey) public virtual isWithinVotingDeadline { | |||
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
0xmad
approved these changes
Feb 16, 2024
|
LGTM! |
ctrlc03
force-pushed
the
fix/msg-type
branch
from
e67d027 to
c547e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce likeliness of issues in the circuits by constraining at the contract level that vote message are type 1.
Confirmation