Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): improve cli integration ux #1212

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Feb 19, 2024

Description

  • Return transaction hash from signup command
  • Add indexed params for signup event
  • Add command to check if user is registered and get state index

Additional Notes

N/A

Related issue(s)

Related to privacy-scaling-explorations/maci-platform#4

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Feb 19, 2024
@0xmad 0xmad self-assigned this Feb 19, 2024
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 7727ab1
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65d4dd7649f74000081d4ed3
😎 Deploy Preview https://deploy-preview-1212--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xmad 0xmad force-pushed the feature/cli-signup-improvements branch 2 times, most recently from 4c5c1ba to 5011207 Compare February 20, 2024 15:51
@0xmad 0xmad marked this pull request as ready for review February 20, 2024 16:01
- [x] Return transaction hash from signup command
- [x] Add indexed params for signup event
- [x] Add command to check if user is registered and get state index
@0xmad 0xmad force-pushed the feature/cli-signup-improvements branch from 5011207 to 7727ab1 Compare February 20, 2024 17:12
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve, just having some questions

contracts/contracts/MACI.sol Show resolved Hide resolved
cli/ts/sdk/index.ts Show resolved Hide resolved
@0xmad 0xmad merged commit 0368201 into dev Feb 20, 2024
19 checks passed
@0xmad 0xmad deleted the feature/cli-signup-improvements branch February 20, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants