Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contracts): prevent user DoS the stateAq tree merging #1218

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(contracts): prevent user DoS the stateAq tree merging #1218

merged 1 commit into from
Feb 20, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Feb 20, 2024 •
edited
Loading

Description

prevent user DoS the stateAq tree merging. Currently a user could signup (gatekeeper allowing) after the subtrees have been merged, and prevent a coordinator from calling mergeStateAq without having to call mergeStateAqSubRoots again.

Confirmation

@netlify Netlify
Copy link

netlify bot commented Feb 20, 2024 •
edited
Loading

✅ Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit d07d3bf
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65d4d37c1a0b2100088a2d77
😎 Deploy Preview https://deploy-preview-1218--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 self-assigned this Feb 20, 2024
0xmad
0xmad approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks but can you update the commit? I think it should be fix.

@0xmad 0xmad changed the title docs(contracts): prevent user DoS the stateAq tree merging fix(contracts): prevent user DoS the stateAq tree merging Feb 20, 2024
@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Feb 20, 2024

ate the commit? I think it should be

oh definitely, my bad

@ctrlc03 ctrlc03 force-pushed the fix/merge-queue-dos branch from 7b42f1f to d07d3bf Compare February 20, 2024 16:29
@ctrlc03 ctrlc03 enabled auto-merge February 20, 2024 16:32
@ctrlc03 ctrlc03 merged commit 2d562e0 into dev Feb 20, 2024
19 checks passed
@ctrlc03 ctrlc03 deleted the fix/merge-queue-dos branch February 20, 2024 16:43
@ctrlc03 ctrlc03 mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@kittybest kittybest Awaiting requested review from kittybest

@samajammin samajammin Awaiting requested review from samajammin

@crisgarner crisgarner Awaiting requested review from crisgarner

Assignees

@ctrlc03 ctrlc03

Labels
None yet
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctrlc03 @0xmad