fix(topup): check valid new state leaf balance #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
force-pushed
the
fix/topup-circuit
branch
from
fe10762 to
c12d79c
Compare
ctrlc03
force-pushed
the
fix/topup-circuit
branch
from
c12d79c to
d32f2dd
Compare
0xmad
approved these changes
Feb 22, 2024
kittybest
reviewed
Feb 22, 2024
ctrlc03
force-pushed
the
fix/topup-circuit
branch
from
d32f2dd to
ec12d2b
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
validCreditBalancecomponent output is not used in the topup calculation. In this PR, we use the output of this component to switch between keeping the previous balance or using the new one.Furthermore, some documentation around the topup feature is also added in the doc website.
Confirmation