Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix typos #1245

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: fix typos #1245

merged 1 commit into from
Feb 26, 2024

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Feb 25, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Feb 25, 2024 •
edited
Loading

✅ Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit bd21f05
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65db36950ec50800089d101f
😎 Deploy Preview https://deploy-preview-1245--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arnaucube arnaucube mentioned this pull request Feb 25, 2024
Merged
ctrlc03
ctrlc03 approved these changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ctrlc03 ctrlc03 self-requested a review February 25, 2024 12:12
ctrlc03
ctrlc03 requested changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run prettier? CI complains about spec.md 🙏 thanks

@rex4539
Copy link
Contributor Author

rex4539 commented Feb 25, 2024

Not sure why it's failing. Looks fine when I run it locally on my branch.

/Users/rex/rex4539-maci/website/versioned_docs/version-v1.x on branch typos rex@MacBook-Pro% npx prettier -c .        
Checking formatting...
All matched files use Prettier code style!

@rex4539 rex4539 requested a review from ctrlc03 February 25, 2024 12:38
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Feb 25, 2024 •
edited
Loading

Not sure why it's failing. Looks fine when I run it locally on my branch.

/Users/rex/rex4539-maci/website/versioned_docs/version-v1.x on branch typos rex@MacBook-Pro% npx prettier -c .        
Checking formatting...
All matched files use Prettier code style!

mm not sure why 🤔 have you run pnpm prettier:fix and commited the changes after that? from the project root

@rex4539
Copy link
Contributor Author

rex4539 commented Feb 25, 2024

Should be ok now.

@ctrlc03 ctrlc03 enabled auto-merge February 26, 2024 09:19
@ctrlc03 ctrlc03 merged commit 6f99cac into privacy-scaling-explorations:dev Feb 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@kittybest kittybest Awaiting requested review from kittybest

@0xmad 0xmad Awaiting requested review from 0xmad 0xmad is a code owner

@samajammin samajammin Awaiting requested review from samajammin

@crisgarner crisgarner Awaiting requested review from crisgarner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rex4539 @ctrlc03