Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): publish a declaration file #879

Merged
merged 1 commit into from
Dec 7, 2023
Merged

chore(core): publish a declaration file #879

merged 1 commit into from
Dec 7, 2023

Conversation

baumstern
Copy link
Member

@baumstern baumstern commented Dec 6, 2023 •
edited
Loading

This PR publish a declaration file of core package

@baumstern baumstern requested review from 0xmad and ctrlc03 December 6, 2023 19:18
@baumstern baumstern self-assigned this Dec 6, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited
Loading

❌ Deploy Preview for maci-typedoc failed.

Name Link
🔨 Latest commit 0b55568
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/657203d1a6ff3400084ad466

@samajammin
Copy link
Member

Thanks @baumstern - could you please add a description? What is the purpose of this PR?

@baumstern
Copy link
Member Author

Thanks @baumstern - could you please add a description? What is the purpose of this PR?

Added. Please take another look

@baumstern baumstern requested a review from samajammin December 7, 2023 11:42
0xmad
0xmad approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baumstern looks good, thanks!

@baumstern baumstern merged commit 88cee6a into dev Dec 7, 2023
11 checks passed
@baumstern baumstern deleted the core-types branch December 7, 2023 21:00
@baumstern baumstern added this to the MACI v1.1.1 refactor milestone Dec 8, 2023
@baumstern baumstern linked an issue Dec 8, 2023 that may be closed by this pull request
Core package refactoring #792
Closed
8 tasks
@baumstern baumstern mentioned this pull request Dec 12, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@ctrlc03 ctrlc03 Awaiting requested review from ctrlc03 ctrlc03 is a code owner

@samajammin samajammin Awaiting requested review from samajammin

Assignees

@baumstern baumstern

Labels
None yet
Projects
MACI
Status: Done
Milestone
MACI v1.1.1 refactor
Development

Successfully merging this pull request may close these issues.

Core package refactoring
3 participants
@baumstern @samajammin @0xmad