Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): apply linter for website and remove unused packages #888

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Dec 7, 2023

  • Remove maci-common
  • Remove maci-server
  • Linter fixes
  • Add linter checks for tsx files
  • Add commitlint workflow

Blocked by #887
Related to #845

@0xmad 0xmad added the chore Chore tasks label Dec 7, 2023
@0xmad 0xmad added this to the MACI v1.1.1 refactor milestone Dec 7, 2023
@0xmad 0xmad self-assigned this Dec 7, 2023
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for maci-typedoc failed.

Name Link
🔨 Latest commit 1a3b343
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65734763235bd60008c8ba38

@0xmad 0xmad force-pushed the chore/linter-website branch 7 times, most recently from 12d4d68 to ef62069 Compare December 7, 2023 22:49
@0xmad 0xmad marked this pull request as ready for review December 7, 2023 23:00
@ctrlc03 ctrlc03 force-pushed the chore/linter-website branch from e6acc19 to d1e0d23 Compare December 7, 2023 23:03
@0xmad 0xmad force-pushed the chore/linter-website branch from d1e0d23 to 55831ee Compare December 7, 2023 23:03
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change request, other than that great stuff!

website/setupTypedoc.ts Outdated Show resolved Hide resolved
baumstern
baumstern previously approved these changes Dec 8, 2023
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! LGTM

- [x] Remove maci-common
- [x] Remove maci-server
- [x] Linter fixes
- [x] Add linter checks for tsx files
- [x] Add commitlint workflow
@0xmad 0xmad force-pushed the chore/linter-website branch from 1ab5d2e to 1a3b343 Compare December 8, 2023 16:42
@0xmad 0xmad merged commit 00a5078 into dev Dec 8, 2023
12 checks passed
@0xmad 0xmad deleted the chore/linter-website branch December 8, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants