-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(website): apply linter for website and remove unused packages #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for maci-typedoc failed.
|
0xmad
force-pushed
the
chore/linter-website
branch
7 times, most recently
from
December 7, 2023 22:49
12d4d68
to
ef62069
Compare
ctrlc03
force-pushed
the
chore/linter-website
branch
from
December 7, 2023 23:03
e6acc19
to
d1e0d23
Compare
0xmad
force-pushed
the
chore/linter-website
branch
from
December 7, 2023 23:03
d1e0d23
to
55831ee
Compare
ctrlc03
requested changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change request, other than that great stuff!
baumstern
previously approved these changes
Dec 8, 2023
ctrlc03
force-pushed
the
chore/linter-website
branch
from
December 8, 2023 16:28
18206b4
to
1ab5d2e
Compare
ctrlc03
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that! LGTM
- [x] Remove maci-common - [x] Remove maci-server - [x] Linter fixes - [x] Add linter checks for tsx files - [x] Add commitlint workflow
0xmad
force-pushed
the
chore/linter-website
branch
from
December 8, 2023 16:42
1ab5d2e
to
1a3b343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #887
Related to #845