test(contracts): re-organize smart contract tests in separate files #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
force-pushed
the
tests/contracts
branch
from
460de17 to
050e788
Compare
baumstern
suggested changes
Dec 11, 2023
ctrlc03
force-pushed
the
tests/contracts
branch
from
050e788 to
7fff4ed
Compare
kittybest
reviewed
Dec 12, 2023
ctrlc03
force-pushed
the
tests/contracts
branch
2 times, most recently
from
3d38c90 to
f9ec261
Compare
baumstern
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Looks good to me! I'll leave it open for @kittybest to take a peek
ctrlc03
force-pushed
the
tests/contracts
branch
3 times, most recently
from
b69e78d to
ad5eac4
Compare
ctrlc03
force-pushed
the
tests/contracts
branch
3 times, most recently
from
70e5198 to
fb9ccb9
Compare
kittybest
approved these changes
Dec 14, 2023
Currently all tests related to a Poll were inside one file (MACI.test) - these tests have been moved into their respective files, re organized and cleaned up, and a small number of test cases were added which were missing.
ctrlc03
force-pushed
the
tests/contracts
branch
from
fb9ccb9 to
c7ee31e
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all tests related to a Poll were inside one file (MACI.test) - these tests have been moved into their respective files, re organized and cleaned up, and a small number of test cases were added which were missing.
re #843