Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): cleanup the core package #907

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 12, 2023

Cleanup and ensure every function has a proper type.

  • Organize files inside the core package for better discoverability
  • ensure that functions have the appropriate return type
  • add missing typedoc comments
  • remove _ from variable names

in reference to #792

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for maci-typedoc failed.

Name Link
🔨 Latest commit f277e48
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/657822df672eed0008551d8b

…s a proper type

Organize files inside the core package for better discoverability, ensure that functions have the
appropriate return type, add missing typedoc comments and remove _ from variable names
@ctrlc03 ctrlc03 force-pushed the refactoring/core-cleanup branch from 09e0798 to f277e48 Compare December 12, 2023 09:07
@ctrlc03 ctrlc03 self-assigned this Dec 12, 2023
Copy link
Member

@baumstern baumstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baumstern baumstern merged commit 685686b into dev Dec 12, 2023
12 checks passed
@baumstern baumstern deleted the refactoring/core-cleanup branch December 12, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants