-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(contracts): deploy MessageProcessor, Tally, and Subsidy contracts after deploy poll #949
Conversation
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1f5d8cb
to
b9fee47
Compare
1db9d5b
to
48605c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @kittybest - left few comments here and there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kittybest thanks, just few comments and could you update PR title to match commit conventions?
48605c1
to
4b903ec
Compare
c1da034
to
fe51956
Compare
c5e2242
to
3d723b1
Compare
10905e2
to
e5743ba
Compare
22afc9a
to
8abb041
Compare
2a5d653
to
dc2822d
Compare
17c0582
to
c89fa38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes.
Please change the title to match commit conventions, then there's one comment but it's just natspec related
c89fa38
to
579a53f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kittybest thanks, just one minor fix.
Description
This is mainly for deploying Poll with MessageProcessor, Tally, and Subsidy(optional) contracts at the same time.
PollFactory
,MessageProcessorFactory
,TallyFactory
,SubsidyFactory
)IMPFactory
,IPollFactory
,ITallySubsidyFactory
) and several smart contracts (IMessageProcessor
,IPoll
,IVkRegistry
)Related issue(s)
close #862.
Confirmation