Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): optimize bundle size #974

Merged
merged 1 commit into from
Jan 9, 2024
Merged

chore(cli): optimize bundle size #974

merged 1 commit into from
Jan 9, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jan 9, 2024

Description

Use separate tsconfig for build and development

Additional Notes

N/A

Related issue(s)

Related to #781

Confirmation

@0xmad 0xmad added the chore Chore tasks label Jan 9, 2024
@0xmad 0xmad added this to the MACI v1.1.1 refactor milestone Jan 9, 2024
@0xmad 0xmad self-assigned this Jan 9, 2024
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 39268b2
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/659dcab8ba0bbc0008b27b32
😎 Deploy Preview https://deploy-preview-974--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Is this something we can (and should) do to other packages if we move out tests from the ts folder?

@ctrlc03 ctrlc03 force-pushed the chore/optimize-build-size branch from da188e8 to 943ab41 Compare January 9, 2024 22:01
@0xmad
Copy link
Collaborator Author

0xmad commented Jan 9, 2024

@ctrlc03 I think I can exclude *.test.ts files and we don't have any of tests in any build folder.

@0xmad 0xmad force-pushed the chore/optimize-build-size branch from 943ab41 to c29ef85 Compare January 9, 2024 22:30
@0xmad 0xmad requested a review from ctrlc03 January 9, 2024 22:30
@0xmad 0xmad force-pushed the chore/optimize-build-size branch from c29ef85 to 6d3b23c Compare January 9, 2024 22:31
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments! thank you

circuits/tsconfig.build.json Outdated Show resolved Hide resolved
cli/tsconfig.build.json Outdated Show resolved Hide resolved
contracts/tsconfig.build.json Outdated Show resolved Hide resolved
domainobjs/tsconfig.build.json Outdated Show resolved Hide resolved
- [x] Use tsconfig.build.json for build stage
- [x] Remove source files from bundle for cli
@0xmad 0xmad force-pushed the chore/optimize-build-size branch from 6d3b23c to 39268b2 Compare January 9, 2024 22:37
@0xmad 0xmad requested a review from ctrlc03 January 9, 2024 22:37
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@0xmad 0xmad merged commit 8cb022e into dev Jan 9, 2024
14 checks passed
@0xmad 0xmad deleted the chore/optimize-build-size branch January 9, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants