Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(publish): fix publishing scripts to publish contracts with ceremony params #984

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 10, 2024

Description

Add environment variable so that contracts can be built using a different state tree depth param, and thus allow for publishing to npm contracts that work with the ceremony params

Related issue(s)

close: #973

Confirmation

@ctrlc03 ctrlc03 self-assigned this Jan 10, 2024
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit f27af1c
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/659ede4f4775f1000916e8fe
😎 Deploy Preview https://deploy-preview-984--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…mony params

Add environment variable so that contracts can be built using a different state tree depth param,
and thus allow for publishing to npm contracts that work with the ceremony params

#973
@ctrlc03 ctrlc03 force-pushed the deps/ceremony-deployment branch from 918ff2c to f27af1c Compare January 10, 2024 18:13
@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 10, 2024

@yuetloo fyi

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@0xmad 0xmad merged commit e45c136 into dev Jan 10, 2024
14 checks passed
@0xmad 0xmad deleted the deps/ceremony-deployment branch January 10, 2024 18:55
@yuetloo
Copy link
Contributor

yuetloo commented Jan 10, 2024

@ctrlc03 , can you please publish a npm package with state depth 6 (for the circuit 6-8-2-3 from the ceremony)? We only use this circuit in testing to make sure we catch any issue sooner rather than at the deployment time.

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 10, 2024

@ctrlc03 , can you please publish a npm package with state depth 6 (for the circuit 6-8-2-3 from the ceremony)? We only use this circuit in testing to make sure we catch any issue sooner rather than at the deployment time.

Yes, will let you know once up (once this is merged I hope #989)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Set EmptyBallotRoot values at contract deploy time instead of at build time
3 participants