Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor probnum.typing #599

Merged

Conversation

marvinpfoertner
Copy link
Collaborator

In a Nutshell

This PR refactors the global probnum.typing module, preparing it for #581.

Detailed Description

  • Renamed all ...ArgTypes to ...Like types
  • Removed ToleranceDiffusionType and DenseOutputLocationArgType, which are just aliases for ArrayLike
  • Added documentation for all types
  • Added some new API types

Related Issues and PRs

#581

@marvinpfoertner marvinpfoertner added documentation Improvements or additions to documentation refactoring Refactoring of existing functionality labels Dec 30, 2021
@marvinpfoertner marvinpfoertner self-assigned this Dec 30, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #599 (6afc3e5) into main (b69587b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         180      180           
  Lines        6668     6670    +2     
  Branches     1025     1025           
=======================================
+ Hits         5960     5962    +2     
  Misses        479      479           
  Partials      229      229           
Impacted Files Coverage Δ
src/probnum/diffeq/_odesolution.py 100.00% <100.00%> (ø)
src/probnum/diffeq/_odesolver.py 100.00% <100.00%> (ø)
...rc/probnum/diffeq/odefilter/_odefilter_solution.py 90.62% <100.00%> (-0.29%) ⬇️
...ter/information_operators/_information_operator.py 100.00% <100.00%> (ø)
...q/odefilter/information_operators/_ode_residual.py 100.00% <100.00%> (ø)
.../odefilter/initialization_routines/_runge_kutta.py 100.00% <100.00%> (ø)
...c/probnum/diffeq/odefilter/utils/_problem_utils.py 100.00% <100.00%> (ø)
...turbed/scipy_wrapper/_wrapped_scipy_odesolution.py 100.00% <100.00%> (ø)
...q/perturbed/scipy_wrapper/_wrapped_scipy_solver.py 100.00% <100.00%> (ø)
...m/diffeq/perturbed/step/_perturbation_functions.py 89.47% <100.00%> (ø)
... and 49 more

Copy link
Contributor

@JonathanWenger JonathanWenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This will be great to u ify interfaces in particular in light of the planned backends.

@marvinpfoertner marvinpfoertner merged commit fced603 into probabilistic-numerics:main Dec 30, 2021
@marvinpfoertner marvinpfoertner deleted the refactor/typing branch December 30, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactoring Refactoring of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants