Skip to content

Commit

Permalink
todaysFactsWidget: Fix broken layout in GNOME 45
Browse files Browse the repository at this point in the history
Using St.ScrollView.add_child() instead of St.ScrollView.add_actor()
leads to broken layout in the ScrollView widget (zero vertical extension
of rows). See
#362 (comment)
and follow-up comments.

But unlike other St Widgets, ScrollView still supports the add_actor() method
in GNOME 46. So keep using it.
  • Loading branch information
mwilck committed Apr 5, 2024
1 parent 99d491a commit cc353e2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion extension/widgets/todaysFactsWidget.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class TodaysFactsWidget extends St.ScrollView {
reactive: true
});
this.factsBox.add_child(this.facts_widget);
this.add_child(this.factsBox);
this.add_actor(this.factsBox);

}

Expand Down

0 comments on commit cc353e2

Please sign in to comment.