Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.st #303

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Update README.st #303

merged 2 commits into from
Apr 28, 2020

Conversation

DirkHoffmann
Copy link
Member

Compatibility with gnome-shell 3.30 according to #301

@DirkHoffmann
Update README.st
4be661f 
Compatibility with gnome-shell 3.30 according to projecthamster#301
@DirkHoffmann
Bump latest validated gnome-shell version (#1)
88ce176 
to 3.30
(probably duplicate)
@DirkHoffmann DirkHoffmann mentioned this pull request Mar 1, 2019
Closed
@projecthamster projecthamster deleted a comment from CLAassistant Mar 6, 2020
@DirkHoffmann DirkHoffmann self-assigned this Mar 6, 2020
@DirkHoffmann
Copy link
Member Author

The latest gnome-shell version known to work is 3.34.
I have to update that before merging.

@DirkHoffmann DirkHoffmann requested a review from mwilck April 27, 2020 22:41
@DirkHoffmann
Copy link
Member Author

I assign you in turn, @mwilck. But probably we have to bump the "last supported version" number to 3.36 anyway by now.

@mwilck
Copy link
Contributor

mwilck commented Apr 27, 2020

Can't we just link to metadata.json, or the commit history? Having to update the README for every new GNOME shell release looks like tedious, pointless, easily-forgotten work to me. The README has obviously been wrong for years.

@mwilck
Copy link
Contributor

mwilck commented Apr 27, 2020

IOW, I propose not to mention an explicit GNOME shell version in the README at all. Rather, we should provide new users guidance how to figure out the right version. We should point them at

mwilck
mwilck approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@mwilck mwilck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I guess rather than discussing, let's simply pull this. We can try to make the README GNOME version-agnostic later.

@mwilck mwilck merged commit 9e0a192 into projecthamster:develop Apr 28, 2020
@mwilck mwilck mentioned this pull request Apr 28, 2020
Merged
@DirkHoffmann DirkHoffmann deleted the patch-2 branch May 2, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwilck mwilck mwilck approved these changes

Assignees

@DirkHoffmann DirkHoffmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DirkHoffmann @mwilck