-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Property layer visualization for HexGrid #2646
base: main
Are you sure you want to change the base?
Fix: Property layer visualization for HexGrid #2646
Conversation
for more information, see https://pre-commit.ci
…Sahil-Chhoker/mesa into property-layer-fix-for-hex-grid
Performance benchmarks:
|
Thanks for this. The example looks great. I am taking a look at the code now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions and ideas. Looks very good already.
Are you sure it's fine as it is? I had a few questions about it:
|
I gave it a first quick pass and focussed on the high-level stuff. The zorder one is a good question (and actually interacts with #2642). Ideally (but beyond this pr), zorder should become controllable for property layers to explicitly control layering. |
Thank you for the review! I have added the suggested changes. Please let me know if you have any additional recommendations to further improve the code quality. |
Summary
Property layers were not properly visualized for HexGrids, and this PR aims to resolve that issue. It utilizes the same coordinate system as the
draw_hex_grid
function and generates aPolyCollection
that overlays color values on the grid.Bug / Issue
fixes #2433
Before
After
Additional Notes:
I am not entirely sure if this was the best approach to address the issue. If there is a more effective or elegant solution, I would greatly appreciate your recommendations.