Merge pull request #81 from gianlucam76/conversion-webhook

(feat) do not start conversion webhook by default
projectsveltos · Dec 11, 2024 · 38f2fad · 38f2fad
2 parents 81c6670 + 9562bb8
commit 38f2fad
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 5 deletions.
diff --git a/charts/projectsveltos/Chart.yaml b/charts/projectsveltos/Chart.yaml
@@ -13,7 +13,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.44.1
+version: 0.44.2
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.

diff --git a/charts/projectsveltos/templates/deployment.yaml b/charts/projectsveltos/templates/deployment.yaml
@@ -597,6 +597,7 @@ metadata:
   name: register-mgmt-cluster
   labels:
   {{- include "projectsveltos.labels" . | nindent 4 }}
+{{ if .Values.webhook.conversion }}
 ---
 apiVersion: apps/v1
 kind: Deployment
@@ -668,4 +669,4 @@ spec:
         secret:
           defaultMode: 420
           secretName: webhook-server-cert
-
+{{ end }}
diff --git a/charts/projectsveltos/templates/project-selfsigned-issuer.yaml b/charts/projectsveltos/templates/project-selfsigned-issuer.yaml
@@ -1,8 +1,10 @@
+{{ if .Values.webhook.conversion }}
 apiVersion: cert-manager.io/v1
 kind: Issuer
 metadata:
   name: project-selfsigned-issuer
   labels:
   {{- include "projectsveltos.labels" . | nindent 4 }}
 spec:
-  selfSigned: {}
+  selfSigned: {}
+{{ end }}
diff --git a/charts/projectsveltos/templates/projectsveltos-mutating-webhook-configuration.yaml b/charts/projectsveltos/templates/projectsveltos-mutating-webhook-configuration.yaml
@@ -1,3 +1,4 @@
+{{ if .Values.webhook.conversion }}
 apiVersion: admissionregistration.k8s.io/v1
 kind: MutatingWebhookConfiguration
 metadata:
@@ -17,4 +18,5 @@ webhooks:
       path: /mutate-projectsveltos-v1beta1-clusterprofile
   failurePolicy: Fail
   name: mclusterprofile.projectsveltos.io
-  sideEffects: None
+  sideEffects: None
+{{ end }}
diff --git a/charts/projectsveltos/templates/projectsveltos-serving-cert.yaml b/charts/projectsveltos/templates/projectsveltos-serving-cert.yaml
@@ -1,3 +1,4 @@
+{{ if .Values.webhook.conversion }}
 apiVersion: cert-manager.io/v1
 kind: Certificate
 metadata:
@@ -12,3 +13,4 @@ spec:
     kind: Issuer
     name: 'project-selfsigned-issuer'
   secretName: webhook-server-cert
+{{ end }}
diff --git a/charts/projectsveltos/templates/webhook-service.yaml b/charts/projectsveltos/templates/webhook-service.yaml
@@ -1,3 +1,4 @@
+{{ if .Values.webhook.conversion }}
 apiVersion: v1
 kind: Service
 metadata:
@@ -10,4 +11,5 @@ spec:
     app: sveltos-webhook
   {{- include "projectsveltos.selectorLabels" . | nindent 4 }}
   ports:
-	{{- .Values.webhookService.ports | toYaml | nindent 2 -}}
+	{{- .Values.webhookService.ports | toYaml | nindent 2 -}}
+{{ end }}
diff --git a/charts/projectsveltos/values.yaml b/charts/projectsveltos/values.yaml
@@ -251,3 +251,5 @@ webhookService:
     protocol: TCP
     targetPort: 9443
   type: ClusterIP
+webhook:
+  conversion: false