Fix insteadOf for HTTPS catalog repo
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/https-catalog
branch
2 times, most recently
from
7605012 to
8f31418
Compare
|
We can't do this with a Note that this restriction doesn't apply for "normal" |
simu
force-pushed
the
fix/https-catalog
branch
from
8f31418 to
003a06c
Compare
simu
changed the title
pushInsteadOf for HTTPS catalog repoinsteadOf for HTTPS catalog repo
simu
force-pushed
the
fix/https-catalog
branch
2 times, most recently
from
18fd648 to
2bca6d6
Compare
We need to configure an additional `insteadOf` for the `ssh://git@`
variant of a HTTPS catalog URL since Commodore will optimistically
rewrite all HTTPS Git URLs to have their `ssh://git@` equivalent as the
push URL to make local component development easier.
We use `git config --add` to set multiple `insteadOf` values for the
same replacement ("base") URL, so that the commands work with older Git
versions.
simu
force-pushed
the
fix/https-catalog
branch
from
2bca6d6 to
c4be731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to configure an additional
insteadOffor thessh://git@variant of a HTTPS catalog URL since Commodore will optimistically rewrite all HTTPS Git URLs to have theirssh://git@equivalent as the push URL to make local component development easier.Fixes #11
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
in the correct changelog section:
bug,enhancement,documentation,change,breaking,dependency,internal