Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container image cleanup GitHub actions #5

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

simu
Copy link
Member

@simu simu commented Jul 26, 2024

After some testing of the initial container image cleanup action, we switch to dataaxiom/ghcr-cleanup-action which handles multi-arch images correctly and refactor the cleanup jobs so that we delete untagged versions after every image build and delete PR tags once the PR is closed (merged or unmerged).

See also actions/delete-package-versions#90

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the following labels so it shows up
    in the correct changelog section:
    bug, enhancement, documentation, change, breaking, dependency, internal

@simu simu added the change label Jul 26, 2024
@simu simu force-pushed the feat/refactor-container-image-prune-action branch 3 times, most recently from 1ab46ff to dfc3502 Compare July 26, 2024 12:39
@simu simu force-pushed the feat/refactor-container-image-prune-action branch 2 times, most recently from f8b4f7b to d6f343c Compare July 26, 2024 14:13
@simu simu marked this pull request as ready for review July 26, 2024 14:14
@simu simu requested a review from a team July 26, 2024 14:14
Switch to dataaxiom/ghcr-cleanup-action which treats multi-arch images
correctly and refactor the cleanup jobs so that we delete untagged
versions every time after building a new image and delete PR tags once
the PR is closed (merged or unmerged).
@simu simu force-pushed the feat/refactor-container-image-prune-action branch from d6f343c to cb7bbe2 Compare July 26, 2024 14:20
Copy link
Contributor

@HappyTetrahedron HappyTetrahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simu simu merged commit 74eea3d into main Jul 26, 2024
8 checks passed
@simu simu deleted the feat/refactor-container-image-prune-action branch July 26, 2024 14:27
@simu simu mentioned this pull request Jul 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants