Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Helm value to configure cleanup job image #130

Merged
merged 1 commit into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions class/backup-k8up.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,3 @@ parameters:
- type: jsonnet
filter: postprocess/optional_global_config.jsonnet
path: ${_instance}/01_k8up_helmchart/k8up/templates
- type: jsonnet
filter: postprocess/cleanup-job.jsonnet
path: ${_instance}/01_k8up_helmchart/k8up/templates
1 change: 1 addition & 0 deletions class/defaults.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ parameters:
helmValues:
replicaCount: 1
image: ${backup_k8up:images:k8up}
cleanup: ${backup_k8up:images:kubectl}
k8up:
enableLeaderElection: true
timezone: "Etc/UTC"
Expand Down
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/references/parameters.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ Please customize K8up image location and tag in this dict instead of directly in

The value of `k8up.tag` in this dict is used by the component to select the CRD YAML to download.

The component uses the contents of field `kubectl` to patch the Helm chart's cleanup job.
This allows users to configure a custom location for the `kubectl` image used by the job.
The component passes field `kubectl` to the Helm chart in value `cleanup`.
This allows users to control which container image is used by the cleanup job.

== `helmValues`

Expand Down
28 changes: 0 additions & 28 deletions postprocess/cleanup-job.jsonnet

This file was deleted.

Loading