Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misconfigured helm value for skipWithoutAnnotation #143

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

haasad
Copy link
Member

@haasad haasad commented Jun 28, 2024

skipWithoutAnnotation is a helm value, not an envvar

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@haasad haasad added the bug Something isn't working label Jun 28, 2024
@haasad haasad force-pushed the fix/helm-skip-without-annotation branch from d2c5f9e to daadaac Compare June 28, 2024 10:27
@haasad haasad merged commit 8d32af0 into master Jun 28, 2024
8 checks passed
@haasad haasad deleted the fix/helm-skip-without-annotation branch June 28, 2024 11:05
Copy link

github-actions bot commented Jun 28, 2024

🚀 This PR has been released as v5.2.2

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants