Simplify tenant role management; allow tenant SA to patch cluster status
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastjan
commented
Jun 4, 2024
| @@ -14,7 +14,6 @@ func SpecificSteps(obj pipeline.Object, data *pipeline.Context) pipeline.Result | |||
| {Name: "delete vault entries", F: vault.HandleVaultDeletion}, | |||
| {Name: "set tenant owner", F: setTenantOwner}, | |||
| {Name: "apply cluster template from tenant", F: applyClusterTemplateFromTenant}, | |||
| {Name: "update Role", F: clusterUpdateRole}, | |||
There was a problem hiding this comment.
This did not update the cluster role. It did update the tenant role. 🙃
bastjan
changed the title
patch cluster status to report compilation metadatapatch cluster status; simplify tenant role managment
bastjan
changed the title
patch cluster status; simplify tenant role managmentpatch cluster status
bastjan
changed the title
patch cluster statuspatch cluster status
2 tasks
bastjan
added a commit
that referenced
this pull request
Jun 4, 2024
Follow up of the cleanup in #272 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows commodore CI to set compilation metadata.
Strongly simplifies tenant role management. The PR assumes the created roles, which always had full
controllerowner references set, are fully controller owned. Changes to those roles get overridden by the controller on the next reconcile.bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog