Fix initialization of GitLab repos #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab returns `404` on a `repository/tree` call if the repo has zero commits. We checked against the error message but the client library started to return a static `404` error which makes our check fail. This commit changes the checking logic to check for the clients static `ErrNotFound` error. This might catch other errors too (repo does not exists at all), but those errors will be caught in the next step.
DebakelOrakel
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab returns
404on arepository/treecall if the repo has zero commits. We checked against the error message but the client library started to return a static404error which makes our check fail.This commit changes the checking logic to check for the clients static
ErrNotFounderror. This might catch other errors too (repo does not exists at all), but those errors will be caught in the next step.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog