fix(troika-three-utils): add support for colorspace_fragment introduced in Three r154
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee r154) to the list of fragment shaders to process in `upgradeShaders()`
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #324.
Color space is applied to a text color using custom shaders in
upgradeShaders()(troika-three-utils/src/DerivedMaterial.js#L306) through injecting custom shader code into theencodings_fragmentshader. The shader has been renamedcolorspace_fragmentin mrdoob/three.js#26206 since Three r154. Since the pre-r154 fragment shader name is kept in the list, this PR shouldn't break compatibility with Three versions before r154.