Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Erroneously formatted files in the project #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ArthurCarli
Copy link

@ArthurCarli ArthurCarli commented Aug 31, 2024

This PR aims at fixing some ill formatted files in the project that causes various build errors. Without this fixes the project cannot be opened in Xcode on my setup.

This PR also removes reference for files not comited in the repo.

Finally this PR also updates the README about where to find the PassRustCore package

The erroneous formatting seems to have been introduced by commit 762239a (between versions 1.7.3 & 1.8.0)

@ArthurCarli ArthurCarli force-pushed the fix/corrupted-xcode-project branch from 0c91cf8 to de8e8ab Compare August 31, 2024 22:56
@ntnhon
Copy link
Collaborator

ntnhon commented Sep 2, 2024

Thanks for the PR. We actually have a process that mirrors the repo from our internal Gitlab to Github, somehow the project file is broken when it arrives here. The file is still correctly formatted in our Gitlab version so those changes are not needed. I'll double check and try to fix the mirroring process.
Regarding the PastRustCore part, we already have this script hooked into the build process as a pre-action

@ArthurCarli
Copy link
Author

Thanks for the PR. We actually have a process that mirrors the repo from our internal Gitlab to Github, somehow the project file is broken when it arrives here. The file is still correctly formatted in our Gitlab version so those changes are not needed. I'll double check and try to fix the mirroring process. Regarding the PastRustCore part, we already have this script hooked into the build process as a pre-action

Thanks for the info & the quick reply. Yep cool if you can have a look about those broken files.

Ok I see, for the script to be run, the correct scheme (iOS in my case) needed to be selected. Worth adding this information in the README.md you think ?

There is also this part about some plist referenced in the project missing in the repo.
Pass-Constant-Black.plist & Pass-Constant-Scienti…
9f40cb2
…st.plist from project in order to make build pass
You think this could come from the same issue a the one that generate broken files during publication process ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants