Fixed compatibility with symfony/forms ^6.3

psalm · Jan 4, 2024 · 1bedc6e · 1bedc6e
1 parent b9511a3
commit 1bedc6e
Show file tree

Hide file tree

Showing 9 changed files with 58 additions and 8 deletions.
diff --git a/src/Stubs/common/Component/Form/AbstractType.stubphp b/src/Stubs/common/Component/Form/AbstractType.stubphp
@@ -8,4 +8,26 @@ namespace Symfony\Component\Form;
  */
 abstract class AbstractType implements FormTypeInterface
 {
+  /**
+   * @param FormBuilderInterface<T> $builder
+   *
+   * @return void
+   */
+  public function buildForm(FormBuilderInterface $builder, array $options){}
+
+  /**
+   * @param FormInterface<T> $form
+   * @param FormView<T> $view
+   *
+   * @return void
+   */
+  public function buildView(FormView $view, FormInterface $form, array $options){}
+
+  /**
+   * @param FormInterface<T> $form
+   * @param FormView<T> $view
+   *
+   * @return void
+   */
+  public function finishView(FormView $view, FormInterface $form, array $options){}
 }
diff --git a/src/Stubs/common/Component/Form/AbstractTypeExtension.stubphp b/src/Stubs/common/Component/Form/AbstractTypeExtension.stubphp
@@ -8,4 +8,26 @@ namespace Symfony\Component\Form;
  */
 abstract class AbstractTypeExtension implements FormTypeExtensionInterface
 {
+  /**
+   * @param FormBuilderInterface<T> $builder
+   *
+   * @return void
+   */
+  public function buildForm(FormBuilderInterface $builder, array $options){}
+
+  /**
+   * @param FormInterface<T> $form
+   * @param FormView<T> $view
+   *
+   * @return void
+   */
+  public function buildView(FormView $view, FormInterface $form, array $options){}
+
+  /**
+   * @param FormInterface<T> $form
+   * @param FormView<T> $view
+   *
+   * @return void
+   */
+  public function finishView(FormView $view, FormInterface $form, array $options){}
 }
diff --git a/src/Stubs/common/Component/Form/Form.stubphp b/src/Stubs/common/Component/Form/Form.stubphp
@@ -5,6 +5,7 @@ namespace Symfony\Component\Form;
 /**
  * @template T
  * @implements FormInterface<T>
+ * @implements \IteratorAggregate<string, FormInterface>
  */
 class Form implements \IteratorAggregate, FormInterface, ClearableErrorsInterface
 {

diff --git a/src/Stubs/common/Component/Form/FormBuilderInterface.stubphp b/src/Stubs/common/Component/Form/FormBuilderInterface.stubphp
@@ -6,6 +6,7 @@ use Symfony\Component\Form\FormTypeInterface;
 
 /**
  * @template T
+ * @template-extends \Traversable<string, FormBuilderInterface>
  * @template-extends FormConfigBuilderInterface<T>
  */
 interface FormBuilderInterface extends \Traversable, \Countable, FormConfigBuilderInterface

diff --git a/src/Stubs/common/Component/Form/FormInterface.stubphp b/src/Stubs/common/Component/Form/FormInterface.stubphp
@@ -5,6 +5,8 @@ namespace Symfony\Component\Form;
 /**
  * @template T
  * @method void clearErrors(bool $deep)
+ * @extends \ArrayAccess<string, FormInterface>
+ * @extends \Traversable<string, FormInterface>
  */
 interface FormInterface extends \ArrayAccess, \Traversable, \Countable
 {

diff --git a/src/Stubs/common/Component/Form/FormTypeInterface.stubphp b/src/Stubs/common/Component/Form/FormTypeInterface.stubphp
@@ -6,6 +6,8 @@ use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
  * @template T
+ * @implements \ArrayAccess<int|string, FormView>
+ * @implements \IteratorAggregate<int|string, FormView>
  */
 interface FormTypeInterface
 {

diff --git a/src/Stubs/common/Component/Form/FormView.stubphp b/src/Stubs/common/Component/Form/FormView.stubphp
@@ -6,14 +6,13 @@ use Symfony\Component\Form\Exception\BadMethodCallException;
 
 /**
  * @template T
+ * @implements \ArrayAccess<int|string, FormView>
+ * @implements \IteratorAggregate<int|string, FormView>
  */
 class FormView implements \ArrayAccess, \IteratorAggregate, \Countable
 {
     /**
-     * @psalm-suppress MixedArrayAssignment
-     * @psalm-suppress InvalidArrayOffset
-     *
-     * @psalm-var array{value: ?T, attr: array<array-key, mixed>}&array<string, mixed>
+     * @psalm-var array{value: ?T, attr: array<string, mixed>, ...}
      */
     public array $vars = [
         'value' => null,
@@ -26,7 +25,7 @@ class FormView implements \ArrayAccess, \IteratorAggregate, \Countable
     public $parent;
 
     /**
-     * @psalm-var array<string, FormView>
+     * @psalm-var array<int|string, FormView>
      */
     public $children = [];
 }
diff --git a/tests/acceptance/acceptance/forms/AbstractTypeExtension.feature b/tests/acceptance/acceptance/forms/AbstractTypeExtension.feature
@@ -11,6 +11,7 @@ Feature: FormType templates
       use Symfony\Component\Form\AbstractTypeExtension;
       use Symfony\Component\Form\Extension\Core\Type\FormType;
 
+      /** @extends AbstractTypeExtension<void> */
       class TestExtension extends AbstractTypeExtension
       {
           public static function getExtendedTypes(): iterable
@@ -30,6 +31,7 @@ Feature: FormType templates
       use Symfony\Component\Form\AbstractTypeExtension;
       use Symfony\Component\Form\Extension\Core\Type\FormType;
 
+      /** @extends AbstractTypeExtension<void> */
       class TestExtension extends AbstractTypeExtension
       {
           public static function getExtendedTypes(): iterable

diff --git a/tests/acceptance/acceptance/forms/FormView.feature b/tests/acceptance/acceptance/forms/FormView.feature
@@ -42,8 +42,7 @@ Feature: Form view
     Then I see these errors
       | Type  | Message                                                      |
       | Trace | $parentView: Symfony\Component\Form\FormView\|null           |
-      | Trace | $children: array<string, Symfony\Component\Form\FormView>    |
+      | Trace | $children: array<int\|string, Symfony\Component\Form\FormView>    |
       | Trace | $viewData: User\|null                                        |
-      | Trace | $attr: array<array-key, mixed>                               |
+      | Trace | $attr: array<string, mixed>                               |
     And I see no other errors
-