suppress MissingClassConstType (PHP 8.3 only feature)

psalm · Dec 21, 2024 · cb7aab0 · cb7aab0
1 parent d6c93a8
commit cb7aab0
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 24 deletions.
diff --git a/src/Handler/ContainerHandler.php b/src/Handler/ContainerHandler.php
@@ -26,6 +26,7 @@
 
 class ContainerHandler implements AfterMethodCallAnalysisInterface, AfterClassLikeVisitInterface, AfterCodebasePopulatedInterface, BeforeAddIssueInterface
 {
+    /** @psalm-suppress MissingClassConstType */
     private const GET_CLASSLIKES = [
         'Psr\Container\ContainerInterface',
         'Symfony\Component\DependencyInjection\ContainerInterface',

diff --git a/src/Test/CodeceptionModule.php b/src/Test/CodeceptionModule.php
@@ -21,27 +21,19 @@
  */
 class CodeceptionModule extends BaseModule
 {
+    /** @psalm-suppress MissingClassConstType */
     private const DEFAULT_TWIG_TEMPLATES_DIR = 'templates';
 
-    /**
-     * @var string
-     */
-    private $twigTemplateDir = self::DEFAULT_TWIG_TEMPLATES_DIR;
+    private string $twigTemplateDir = self::DEFAULT_TWIG_TEMPLATES_DIR;
 
-    /**
-     * @var FilesystemCache|null
-     */
-    private $twigCache;
+    private ?FilesystemCache $twigCache = null;
 
-    /**
-     * @var string|null
-     */
-    private $lastCachePath;
+    private ?string $lastCachePath = null;
 
     /**
      * @var list<string>
      */
-    private $suppressedIssueHandlers = [];
+    private array $suppressedIssueHandlers = [];
 
     public function _initialize(): void
     {

diff --git a/src/Twig/CachedTemplatesMapping.php b/src/Twig/CachedTemplatesMapping.php
@@ -13,24 +13,19 @@
 class CachedTemplatesMapping implements AfterCodebasePopulatedInterface
 {
     /**
+     * @psalm-suppress MissingClassConstType
      * @var string
      */
     public const CACHED_TEMPLATE_HEADER_PATTERN =
         'use Twig\\\\Template;\n\n'.
         '\/\* (?<name>@?.+\.twig) \*\/\n'.
         'class (?<class>__TwigTemplate_[a-z0-9]{64}) extends (\\\\Twig\\\\)?Template';
 
-    /**
-     * @var string|null
-     */
-    private static $cachePath;
+    private static ?string $cachePath = null;
 
-    /**
-     * @var CachedTemplatesRegistry|null
-     */
-    private static $cacheRegistry;
+    private static ?CachedTemplatesRegistry $cacheRegistry = null;
 
-    public static function afterCodebasePopulated(AfterCodebasePopulatedEvent $event)
+    public static function afterCodebasePopulated(AfterCodebasePopulatedEvent $event): void
     {
         $codebase = $event->getCodebase();
 

diff --git a/src/Twig/TemplateFileAnalyzer.php b/src/Twig/TemplateFileAnalyzer.php
@@ -35,7 +35,7 @@ public static function initExtensions(array $extensionClasses): void
 
     public function analyze(
         ?PsalmContext $file_context = null,
-        ?PsalmContext $global_context = null
+        ?PsalmContext $global_context = null,
     ): void {
         $codebase = $this->project_analyzer->getCodebase();
         $taint = $codebase->taint_flow_graph;

diff --git a/tests/acceptance/acceptance/console/ConsoleArgument.feature b/tests/acceptance/acceptance/console/ConsoleArgument.feature
@@ -2,7 +2,8 @@
 Feature: ConsoleArgument
 
   Background:
-    Given I have Symfony plugin enabled
+    Given I have issue handler "MissingClassConstType" suppressed
+    And I have Symfony plugin enabled
     And I have the following code preamble
       """
       <?php