Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds error message to frontend if try to upload anything other than x… #133

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

benptc
Copy link
Contributor

@benptc benptc commented Apr 14, 2020

…ml, dat, jpg, or zip to the dropzone. also allows xml upload via dropzone independently from dat, previously you had to upload together or it would be generated automatically

Fixes issue #123 (along with previous PR)

…ml, dat, jpg, or zip to the dropzone. also allows xml upload via dropzone independently from dat, previously you had to upload together or it would be generated automatically
@benptc benptc requested a review from hobinjk-ptc April 14, 2020 18:16
@benptc
Copy link
Contributor Author

benptc commented Apr 14, 2020

Message looks like:

Screen Shot 2020-04-14 at 2 04 28 PM

Copy link
Contributor

@hobinjk-ptc hobinjk-ptc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It would also be good to reject model targets

@benptc
Copy link
Contributor Author

benptc commented Apr 14, 2020

Nice! It would also be good to reject model targets

Do you know which file format model targets are? They would be rejected by this unless they are also packaged as a dat or a zip, in which case I'll need to look into some other distinguishing factor

@hobinjk-ptc
Copy link
Contributor

They're also a zip but they contain XML with QCARConfig > Tracking > ModelTarget

@benptc
Copy link
Contributor Author

benptc commented Apr 14, 2020

Created issue #135 to follow up about the model targets

@benptc benptc merged commit 90f36e7 into master Apr 14, 2020
@benptc benptc deleted the more-frontend-notifications branch April 14, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants