Fixed escaped quote on 'revision you submitted' email message #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @petenelson |
stevejburge
modified the milestones:
3.5.17: Bug Fixes,
3.8.0: Settings Improvements,
3.6.2: Settings Improvements,
3.6.1: Small Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "A revision to the..." email message is being run through
esc_html(), then the escaped double-quote is being converted back to plain text here: https://github.com/publishpress/PublishPress-Revisions/blob/master/admin/revision-action_rvy.php#L445However, the "The revision you submitted for the..." email message is being escaped, but the escaped quote is not being converted back to plain text here: https://github.com/publishpress/PublishPress-Revisions/blob/master/admin/revision-action_rvy.php#L531
Example:
This PR fixes this formatting issue, and I also saw the same thing happening in a few other spots in
revision-action_rvy.php