Merge pull request #28 from viktorzavadil/master

Fix median function: sort by numbers
pugulist · Jun 8, 2022 · 6181b06 · 6181b06
2 parents 20bffc7 + e0c6300
commit 6181b06
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -15,9 +15,9 @@ let median = numbers => {
         return null;
     }
     let median = 0, numsLen = numbers.length;
-    numbers.sort();
+    numbers = numbers.sort((a, b) => a - b);
 
-    if (numbers.length % 2 == 0) {
+    if (numbers.length % 2 === 0) {
         median = (numbers[numsLen / 2 - 1] + numbers[numsLen / 2]) / 2;
     } else {
         median = numbers[(numsLen - 1) / 2];

diff --git a/test/test.js b/test/test.js
@@ -18,6 +18,10 @@ describe('#stats', function() {
         var result = stats.median(1);
         expect(result).to.equal(null);
     });
+    it('Median from numbers with more ciphers', function() {
+        var result = stats.median([1, 2, 22, 3, 33]);
+        expect(result).to.equal(3);
+    });
     it('Not an array error mean', function() {
         var result = stats.mean(1);
         expect(result).to.equal(null);