Don't cache Java executors #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we fail to execute a Java command, we currently duplicate the command name (e.g. `mvn`), which makes it harder to understand what has gone wrong. This commit cleans this up, additionally quoting the command we attempted to run so that it's easier to parse in the event it contains spaces.
Presently, the Java language host caches a single executor, which abstracts e.g. the command-line executions needed to run Java code. This is problematic should a single language runtime ever be fielded with concurrent requests for program execution. This commit removes this caching for now to fix this.
lunaris
added
the
impact/no-changelog-required
tgummerer
approved these changes
Nov 18, 2024
Frassle
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, the Java language host caches a single executor, which abstracts e.g. the command-line executions needed to run Java code. This is problematic should a single language runtime ever be fielded with concurrent requests for program execution. This commit removes this caching for now to fix this.