Implement GenerateProgram and GenerateProject
#1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunaris
force-pushed
the
wjones/gen-prog-proj
branch
from
f824ff9 to
97337d4
Compare
Frassle
approved these changes
Nov 18, 2024
The `GenerateProgram` and `GenerateProject` methods of the `LanguageRuntime` gRPC service allow callers to generate programs (in this case, Java source code) and projects (programs complete with e.g. build and packaging components -- in this case, Maven `pom.xml`s and so on). This commit implements these endpoints for `pulumi-language-java`, using the functionality that already exists but previously was only exposed through the `pulumi-java-gen` binary. Doing so means we can begin to get conformance tests (which generate programs using RPC calls) working for Java. Note that as part of this, we add support for local (packed) dependencies to `GenerateProject`, which is key to enabling conformance tests also. We do this by harnessing Maven's existing `<repositories>` tag, which allows specifying paths to non-default Maven repositories where it can find `.jar`s etc. This will tie in with our later implementation of `Pack`, which will produce local Maven repositories containing built `.jar`s.
lunaris
force-pushed
the
wjones/gen-prog-proj
branch
from
97337d4 to
24e37bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenerateProgramandGenerateProjectmethods of theLanguageRuntimegRPC service allow callers to generate programs (in this case, Java source code) and projects (programs complete with e.g. build and packaging components -- in this case, Mavenpom.xmls and so on). This commit implements these endpoints forpulumi-language-java, using the functionality that already exists but previously was only exposed through thepulumi-java-genbinary. Doing so means we can begin to get conformance tests (which generate programs using RPC calls) working for Java.Note that as part of this, we add support for local (packed) dependencies to
GenerateProject, which is key to enabling conformance tests also. We do this by harnessing Maven's existing<repositories>tag, which allows specifying paths to non-default Maven repositories where it can find.jars etc. This will tie in with our later implementation ofPack, which will produce local Maven repositories containing built.jars.