Implement GeneratePackage
#1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GeneratePackage` method of the `LanguageRuntime` gRPC service allows callers to generate SDKs for a specified schema. This commits implements this endpoint for `pulumi-language-java`, using the existing `pkg/codegen` functionality that is currently only exposed through the `pulumi-java-gen` binary. Doing so means we can begin to get conformance tests working for Java. As part of this work, we extend the work we started when implementing `GenerateProject` to support local repositories in generated SDKs. As with other languages, we add a field to `PackageInfo` to this end. Since SDK generation uses Gradle (and not Maven, as program generation does), there is a bit of new plumbing to do here, but in principle the outcome is the same. > [!NOTE] > It is not certain yet that `GeneratePackage` behaves identically to the > currently-used binary endpoint in `pulumi-java-gen` -- we should make sure of > this before switching over. This work is primarily a means to get conformance > tests going.
lunaris
force-pushed
the
wjones/gen-pkg
branch
from
dcc5fce to
7953df6
Compare
Frassle
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GeneratePackagemethod of theLanguageRuntimegRPC service allows callers to generate SDKs for a specified schema. This commits implements this endpoint forpulumi-language-java, using the existingpkg/codegenfunctionality that is currently only exposed through thepulumi-java-genbinary. Doing so means we can begin to get conformance tests working for Java.As part of this work, we extend the work we started when implementing
GenerateProjectto support local repositories in generated SDKs. As with other languages, we add a field toPackageInfoto this end. Since SDK generation uses Gradle (and not Maven, as program generation does), there is a bit of new plumbing to do here, but in principle the outcome is the same.Note
It is not certain yet that
GeneratePackagebehaves identically to the currently-used binary endpoint inpulumi-java-gen-- we should make sure of this before switching over. This work is primarily a means to get conformance tests going.