[program-gen] Fix generation of double literals in generated programs
#1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: tests should be fixed now ✅ |
lunaris
approved these changes
Jan 9, 2025
Zaid-Ajaj
added a commit
that referenced
this pull request
Jan 9, 2025
### Description Fixes how we are generating map and array literals when they are _untyped_. The problem was that we generated just the elements i.e. `[1, 2, 3]` in PCL would generate `1, 2, 3` in java because Array-typed resource inputs accepts the elements being spread like that i.e. `resourceInputs = [1,2,3]` (PCL) generated `resourceInputs(1, 2, 3)` (Java). However this doesn't work when we are initializing lists and maps outside of resource inputs: local variables and output variables. This PR addresses the problem by using `Map.ofEntries(...)` and `List.of(...)` when applicable. Branch is written on top of #1580 - Fixes #1561 - Fixes #1560 - Unskips `l1-output-map` - Unskips `l1-output-array`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an initial pass for handling
__convertcalls in program-gen starting withdoubleliterals. Later on we will extend this to handle enums but we don't have a conformance test for these yet.The return type of
__convertcalls is annotated with the target schema type so we detect when are going to emit an expression of typemodel.NumberType(in PCL space) in a location that expectsschema.NumberType. When that pattern is detected we make sure to emit double literals that end with.0when the value of the number is exact.l2-resource-primitivenow that the test is passingRemovesl2-map-keysas there is no such test