Panic if asked to generate multi-argument invokes #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, Java code generation does not support the `MultiArgumentInputs` field on invokes. When set, this flag instructs the generation of functions that take multiple independent arguments instead of a single object containing all arguments. For example, instead of: ```java Class.function(FunctionArgs.build().setA(a).setB(b).build()); ``` we might generate: ```java Class.function(a, b); ``` Since it is not supported, the correct behaviour is to panic and abort code generation, as we do in other languages with this limitation (e.g. Python). Currently, however, Java does not, proceeding instead to generate incorrect code. This change fixes that, panicking if `MultiArgumentInputs` is true. This is technically breaking, but a bug fix (and in theory, any SDKs we have generated would already be panicking for Python, so the feeling is that this likely not a highly used feature). Fixes #1598
lunaris
force-pushed
the
wjones/multi-arg-sig-panics
branch
from
e2d4d4a to
5774393
Compare
julienp
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, Java code generation does not support the
MultiArgumentInputsfield on invokes. When set, this flag instructs the generation of functions that take multiple independent arguments instead of a single object containing all arguments. For example, instead of:we might generate:
Since it is not supported, the correct behaviour is to panic and abort code generation, as we do in other languages with this limitation (e.g. Python). Currently, however, Java does not, proceeding instead to generate incorrect code. This change fixes that, panicking if
MultiArgumentInputsis true. This is technically breaking, but a bug fix (and in theory, any SDKs we have generated would already be panicking for Python, so the feeling is that this likely not a highly used feature).Fixes #1598