Allow for a Type: 'boolean' to validate when property value is a stri…

…ngified bool
pulumi · Oct 28, 2024 · 078e63e · 078e63e
1 parent 7dd77ef
commit 078e63e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/pkg/tfbridge/typechecker/typechecker.go b/pkg/tfbridge/typechecker/typechecker.go
@@ -161,7 +161,8 @@ func (v *TypeChecker) validatePropertyValue(
 
 	switch typeSpec.Type {
 	case "boolean":
-		if !propertyValue.IsBool() {
+		// The bridge permits the strings "true" and "false" to read as boolean, so allow strings.
+		if !propertyValue.IsBool() && !propertyValue.IsString() {
 			return []Failure{newTypeFailure(propertyPath, typeSpec.Type, propertyValue)}
 		}
 		return nil

diff --git a/pkg/tfbridge/typechecker/typechecker_test.go b/pkg/tfbridge/typechecker/typechecker_test.go
@@ -1631,6 +1631,11 @@ func TestValidateConfigType(t *testing.T) {
 				})),
 			}),
 		},
+		{
+			name:      "allows_bool_strings",
+			inputName: "skipMetadataApiCheck",
+			input:     resource.PropertyValue{V: "true"},
+		},
 	}
 	for _, tc := range testCases {
 		tc := tc
@@ -1661,6 +1666,11 @@ func TestValidateConfigType(t *testing.T) {
 								},
 							},
 						},
+						"skipMetadataApiCheck": {
+							TypeSpec: pschema.TypeSpec{
+								Type: "boolean",
+							},
+						},
 					},
 				},
 			}